Ask to run generate proto tasks after projects are imported #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
force-pushed
the
cs/protobuf-auto-generate
branch
from
9cf69ee
to
5fa724e
Compare
jdneo
requested review from
rgrunber,
CsCherrYY,
Eskibear,
fbricon,
snjeza and
testforstephen
After projects are imported, check if any of the projects contains the classpath entry having 'protobuf_generated_source' attribute and is empty. If we found such projects, ask users to run 'generateProto' and `generateTestProto` Gradle tasks to generate those Java source files. Signed-off-by: Sheng Chen <[email protected]>
jdneo
force-pushed
the
cs/protobuf-auto-generate
branch
from
5fa724e
to
983ec85
Compare
|
test this please |
...pse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/framework/protobuf/ProtobufSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <[email protected]>
...pse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/framework/protobuf/ProtobufSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <[email protected]>
testforstephen
approved these changes
Aug 26, 2022
…nerate Signed-off-by: Sheng Chen <[email protected]>
rgrunber
reviewed
Aug 29, 2022
| if (!projectUris.isEmpty()) { | ||
| ActionableNotification notification = new ActionableNotification().withSeverity(MessageType.Info) | ||
| .withMessage("Would you like to generate Java source files out of your proto files?") | ||
| .withCommands(Arrays.asList(new Command("Yes", "java.protobuf.generateSources", Arrays.asList(projectUris)))); |
There was a problem hiding this comment.
@jdneo I've tested the change and it works well. Apologies for taking long. Regarding the prompt, I would change "Yes" to "Generate". I think if we have a Yes/No dialog but we only want to display the action that does something, then we can just name it by the action that will be taken.
There was a problem hiding this comment.
gayanper
pushed a commit
to gayanper/eclipse.jdt.ls
that referenced
this pull request
Sep 8, 2022
…jdtls#2195) * Ask to run generate proto task after projects import After projects are imported, check if any of the projects contains the classpath entry having 'protobuf_generated_source' attribute and is empty. If we found such projects, ask users to run 'generateProto' and `generateTestProto` Gradle tasks to generate those Java source files. Signed-off-by: Sheng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After projects are imported, check if any of the projects contains the
classpath entry having 'protobuf_generated_source' attribute and is empty.
If we found such projects, ask users to run 'generateProto' and
generateTestProtoGradle tasks to generate those Java source files.
How to test this PR
Signed-off-by: Sheng Chen [email protected]