Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing completion items for fully qualified name completion #2736

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Jun 30, 2023

  • Filter text must be align with the replaced range which is defined in the text edit.

fix redhat-developer/vscode-java#3173

@testforstephen
Copy link
Contributor

fqn_completion.mp4

The usual qualified name completion works well. But it still doesn't work for the case new java.util.Arr|, which doesn't complete the (). If it's not related with this PR, free free to merge this PR first and open a new PR to fix it.

@rgrunber rgrunber added this to the End July 2023 milestone Jul 4, 2023
@rgrunber
Copy link
Contributor

rgrunber commented Jul 4, 2023

I've also seen the behaviour described above where selecting a constructor doesn't include the empty round brackets. It seems to work other times though.

@jdneo
Copy link
Contributor Author

jdneo commented Jul 5, 2023

I'll take a look

jdneo added 2 commits July 6, 2023 11:08
- Filter text must be align with the replaced range which is defined
  in the text edit.

Signed-off-by: sheche <[email protected]>
@jdneo
Copy link
Contributor Author

jdneo commented Jul 6, 2023

But it still doesn't work for the case new java.util.Arr|

The root cause is that we should always update the filter text according to the range of the text edit. Previously, we only update it when the completion proposal kind is TYPE_REF. This should be a bug already exists before. See the change: 00ecd16

But I have no idea why on my side, the completion list does not contain the type completion for ArrayList, I only have the constructor. I've already rebase the PR and reload the target platform. Strange 🤔
image

Signed-off-by: Sheng Chen <[email protected]>
@rgrunber
Copy link
Contributor

If this is safe for inclusion in the 1.26.0 release, feel free to merge.

@testforstephen testforstephen merged commit 9eb1075 into eclipse-jdtls:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion list for java.util is missing some items
3 participants