Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XBase to 2023-06 version #2766

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Update XBase to 2023-06 version #2766

merged 1 commit into from
Jul 19, 2023

Conversation

akurtakov
Copy link
Contributor

No description provided.

@rgrunber rgrunber merged commit 9c2a29d into eclipse-jdtls:master Jul 19, 2023
@rgrunber rgrunber added this to the End July 2023 milestone Jul 19, 2023
@rgrunber rgrunber added the dependencies Pull requests that update a dependency file label Jul 19, 2023
@rgrunber
Copy link
Contributor

rgrunber commented Jul 19, 2023 •
edited
Loading

Tested out by confirming type hierarchy still works, and it does. I guess this is fine for now.

@akurtakov Is there anything stopping us from reducing existing usage in our codebase much like eclipse-lsp4j/lsp4j#494 . Not sure if we can outright remove it if other deps from platform are depending on it.

@akurtakov
Copy link
Contributor Author

Nothin in platform requires it. And as lsp4j is getting rid of it that should be doable task.

@akurtakov
Copy link
Contributor Author

@rgrunber THinking more about it - it's not worth the effort. When #2033 lands this code will be gone so not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
End July 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@akurtakov @rgrunber