Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MrTree nested in a compound node causes incorrect positioning of the sublayout #1059

Closed
Eddykasp opened this issue Aug 1, 2024 · 0 comments · Fixed by #1060
Closed

MrTree nested in a compound node causes incorrect positioning of the sublayout #1059

Eddykasp opened this issue Aug 1, 2024 · 0 comments · Fixed by #1060
Labels
alg-mrtree Affects the ELK Mr. Tree algorithm. bug Erroneous behaviour.
Milestone
Release 0.9.2

Comments

@Eddykasp
Copy link
Contributor

Eddykasp commented Aug 1, 2024 •
edited
Loading

Describe the bug
Example Graph

The MrTree sublayout is positioned incorrectly within the parent node. It is shifted to the bottom right.
See the original issue: kieler/elkjs#294

Expected behavior
The inner layout should be positioned entirely within the containing node.

ELK Version
0.9.0 - 0.9.3

Last Working Version
0.8.1
@Eddykasp Eddykasp added bug Erroneous behaviour. alg-mrtree Affects the ELK Mr. Tree algorithm. labels Aug 1, 2024
@Eddykasp Eddykasp added this to the Release 0.9.2 milestone Aug 1, 2024
@Eddykasp Eddykasp changed the title MrTree nested within MrTree causes incorrect positioning of the sublayout MrTree nested in a compound node causes incorrect positioning of the sublayout Aug 2, 2024
@Eddykasp Eddykasp mentioned this issue Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
alg-mrtree Affects the ELK Mr. Tree algorithm. bug Erroneous behaviour.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging a pull request may close this issue.

Fix an incorrect calculation of how to shift a mrtree layout. Eddykasp/elk
1 participant
@Eddykasp