Repositories from settings get replaced by the default repository and m2e wrongly report errors

[glhez]

Hello,

I am using several remote repositories - four, and some being corporate - and m2e trigger warning about missing dependencies whenever I edit my POM file.

The dependency is inside a corporate repository, whose content is of course not accessible in central.
The dependency was already downloaded by mvn (using mvn clean install...) but somehow, m2e tries to download it again - perhaps to check if it is up to date.

1. In a previous PR/issue (lemminx-maven completely ignore local settings  #196), I had the same kind of problem with the local repo path, which was overridden by some default value. It failed because I created a file ~/.m2/repository
2. The repositories are overridden from settings by the "default":

   lemminx-maven/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java

   Line 224 in 437daf6

   List<ArtifactRepository> defaultRemoteRepositories = Collections.singletonList(repositorySystem.createDefaultRemoteRepository());

   (this is on master branch)

The code should perhaps be something like:

List<ArtifactRepository> repositories = mavenRequest.getRemoteRepositories()
if (repositories.isEmpty()) repositories.add(defaultRemoteRepositories);
List<ArtifactRepository> pluginRepositories = mavenRequest.getPluginArtifactRepositories()
if (pluginRepositories .isEmpty()) pluginRepositories .add(defaultRemoteRepositories);

However, I fail to understand why this code differ from whatever is done when importing the maven project ? (since I only have this error when editing the pom file).

(I can do a PR to apply the code above)

[mickaelistria]

Sure, please try submitting a PR for this change. Note that usually it's not a good thing to modify the lists that are returned by getters when there is a setter, so the pattern should be more

List<Blah> newValue = new ArrayList<>(mavenRequest.getBlah());
newValue.add(additionalValue);
mavenRequest.setBlah(newValue);