From 0615cc5667603391933447151fc3bd53f8a2c10a Mon Sep 17 00:00:00 2001 From: angelozerr Date: Sat, 3 Nov 2018 09:40:01 +0100 Subject: [PATCH] Comment where xsi compeltions must be done (see #163) --- .../participants/ContentModelCompletionParticipant.java | 3 +++ .../lsp4xml/extensions/xsd/XSDCompletionParticipant.java | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java b/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java index 2752f659d..998918fb3 100644 --- a/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java +++ b/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java @@ -97,6 +97,9 @@ private void fillWithChildrenElementDeclaration(Collection @Override public void onAttributeName(boolean generateValue, Range fullRange, ICompletionRequest request, ICompletionResponse response) throws Exception { + // TODO: manage xsi: completions + + // otherwise, manage completion based on XML Schema, DTD. Element parentElement = request.getNode().isElement() ? (Element) request.getNode() : null; if (parentElement == null) { return; diff --git a/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/XSDCompletionParticipant.java b/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/XSDCompletionParticipant.java index 4bd51c18b..0f961610a 100644 --- a/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/XSDCompletionParticipant.java +++ b/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/XSDCompletionParticipant.java @@ -24,6 +24,6 @@ public class XSDCompletionParticipant extends CompletionParticipantAdapter { @Override public void onAttributeName(boolean generateValue, Range fullRange, ICompletionRequest request, ICompletionResponse response) throws Exception { - // TODO: manage xsi: completions + // TODO: manage compeltion for types declared in XML Schema xsd } }