Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault Tolerance 1.1 spec is missing property to disable metrics integration #300

Closed
Azquelt opened this issue Aug 14, 2018 · 0 comments
Closed

Comments

@Azquelt
Copy link
Member

Azquelt commented Aug 14, 2018

When we added metrics integration in #257, we specified a property to disable the metrics integration: MP_Fault_Tolerance_Metrics_Enabled

When we updated the spec to allow annotations to be explicitly enabled in #275, we accidentally removed the section that referred to MP_Fault_Tolerance_Metrics_Enabled

The TCK that tests that this property works is still present: https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/metrics/MetricsDisabledTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant