Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for sorting tags alphabetically in JSON output #572

Open
jmartisk opened this issue Apr 14, 2020 · 3 comments
Open

Remove requirement for sorting tags alphabetically in JSON output #572

jmartisk opened this issue Apr 14, 2020 · 3 comments

Comments

@jmartisk
Copy link
Contributor

OpenMetrics format doesn't have such requirement either.
Implementations can still decide to do it if they want to.

This also requires changes to the TCK tests so that they will pass even if the output is not sorted.

@rmannibucau
Copy link
Contributor

Hi @jmartisk , can this requirement stay? This makes everthing deterministic and easier to integrate overall and it does not cost much in java side so think it is worth keeping - very worse case, the spec shouldn't forbid impl to do that.

@jmartisk
Copy link
Contributor Author

This was just some kind of an idea, I'm not really sure if we want to do this. And doing this would mean changing the TCK, as stated in the description, and that would not be a very easy thing to implement, and the already (IMO) ugly TCK code would get even worse.

@donbourne
Copy link
Member

donbourne commented Jul 23, 2020

sorting tags also makes it easier for people to scan through a list of metrics and see which ones have the same tags... so there's some benefit to it.

I don't have a strong opinion either way on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants