Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtend editor trashes local history #3184

Open
dpetroff opened this issue Sep 3, 2024 · 6 comments
Open

Xtend editor trashes local history #3184

dpetroff opened this issue Sep 3, 2024 · 6 comments

Comments

@dpetroff
Copy link

dpetroff commented Sep 3, 2024

Is it possible that Xtend editor is doing something to trash my local history? Based on nobody else experiencing the linked issue, I wonder if it's somehow Xtend-specific.

@cdietrich
Copy link
Member

cdietrich commented Sep 3, 2024

Can you give more context?
on which files do you see this.
where and how do you invoke the local history
Is there any details in the error log ?
Do you see this in a fresh workspace / project?
is any of the files in a xtext or xtend output folder?

@dpetroff
Copy link
Author

dpetroff commented Sep 3, 2024

There are more details about the specific versions in the linked issue but the gist of it is:

In a workspace with local history limit disabled and no other local history settings changed, after a workspace migration (eclipse updated to the next release version via eclipse setup/oomph).
This happened in a fresh workspace twice, after June 2023 and after June 2024 updates. But it did not happen after September 2023 update (or whenever the between version was).
Xtext and Xtend files in the usual non-generated source folder structures. Java files are not affected.
I open local history via the usual Team -> show local history or Replace with -> local history.
There are no errors in the log.
I do not see this in a fresh workspace.
I do see this in new projects that I create in the already broken workspace
None of the files are in output folders, local history is disabled for derived resources by default.

@cdietrich
Copy link
Member

And other files like txt or xml ?

@dpetroff
Copy link
Author

dpetroff commented Sep 4, 2024

txt and xml are affected. Java remains immune.

@cdietrich
Copy link
Member

cdietrich commented Sep 4, 2024

I assume this is cause the editors have a different way how they use documents / editor base classes
Maybe something to report to the other issue

TextFileDocumentProvider vs FileDocumentProvider

@dpetroff
Copy link
Author

dpetroff commented Sep 4, 2024

I tried editing using the "Generic Text Editor" on all the files and that didn't break .java nor unbreak the other file types, so it seems unlikely that it's anything to do with the editors. I also can't imagine why .java files would be special to local history, but considering that other file types are affected, it seems even more unlikely that it's an Xtext/Xtend issue than I thought in the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants