-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed 'grib_errors' parameter to 'errors' to match open_file() signature #349
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
===========================================
- Coverage 95.65% 53.93% -41.73%
===========================================
Files 26 26
Lines 2073 2073
Branches 238 231 -7
===========================================
- Hits 1983 1118 -865
- Misses 59 937 +878
+ Partials 31 18 -13
☔ View full report in Codecov by Sentry. |
… python-eccodes not available for it
This is a really nice PR, @Metamess, I'm just trying to sort out the CI before merging. |
Thank you very much for this PR - you also mentioned that the test environment needed to be updated and you were right, it did just in order for this to work! That was because it required a newer ecCodes, which in turn had some new requirements, and was not supported by Python 3.7. |
Thanks a lot for all the additional work Iain! Glad I could be of help 😁 |
Closes #348
Fixes a bug where providing
"grib_errors"
as key in backend_kwargs is required by some function (open_variable_datasets()
) but causes a TypeError due to not being a recognized parameter in others (CfGribBackend.open_dataset()
).Also fixes a test (
test_40_xarray_store.py::test_open_dataset_corrupted()
) to specifically expect the type of Error associated with the expected issue, which was masking the TypeError.Additionally, also adds the following line to
test_40_xarray_store.py::test_open_dataset()
:xarray_store.open_dataset(TEST_DATA, backend_kwargs={"errors": "raise"})
This tests that calling
open_dataset()
with a known-good GRIB file and"errors": "raise"
does not, in fact, raise an Error.