Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Navbar for edamontology website. #3

Open
Uttam-Singhh opened this issue Apr 16, 2021 · 5 comments
Open

Create a Navbar for edamontology website. #3

Uttam-Singhh opened this issue Apr 16, 2021 · 5 comments
Labels

Comments

@Uttam-Singhh
Copy link
Contributor

To create a navbar for edamontology website - http://edamontology.org/page.

I am working on this issue.

Co-authored under: @matuskalas

@Uttam-Singhh
Copy link
Contributor Author

Uttam-Singhh commented Apr 17, 2021

Hello @matuskalas
Just wanted a quick, what do you think about this navbar, does it looks good?
Also, do you want a specific color for the navbar or this is fine?
edaaaam

@Uttam-Singhh
Copy link
Contributor Author

Uttam-Singhh commented Apr 17, 2021

If you think this is good then please give me a signal so that I can create a PR. @matuskalas

@matuskalas
Copy link
Member

Sorry for a slow reaction🙇🏽‍♂️ I love the navbar, and the colour is perfect!!!! 👍🏽

(maybe we'll want to replace the "EDAM" text by the logo when we agree on one, see incoming ideas in https://github.com/edamontology/logoi. But this is not urgent.)

I think it's all awesome, there is just a couple of (hopefully) minor things I found when I tested your PR #5 (see there).

Million thanks! 🙏🏽

@Uttam-Singhh
Copy link
Contributor Author

Thank you @matuskalas!
I will work on the changes requested.
Sure! I will add the logo in place of "EDAM", later on, when we have a logo( Please let me know)

@Uttam-Singhh
Copy link
Contributor Author

@matuskalas Can you please let me know if I need to improve anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants