Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to download OS specific files only to specified directory #34

Open
buhund opened this issue Mar 18, 2018 · 1 comment

Comments

@buhund
Copy link

buhund commented Mar 18, 2018

Hello! Awesome utility, this! But I have encountered a little trouble trying to use it:

I've successfully downloaded files to an external disk, with default gogrepo.py, by running

cd /media/USER/DISK/Games/GOGrepo/gogrepo-master
./gogrepo update
./gogrepo download /media/USER/DISK/Games/GOGrepo/gogrepo-library/

I then found that it was only the Windows files being downloaded, which I assume is a result of line 113 in gogrepo.py:

DEFAULT_OS_LIST = ['windows']

I updated this to

DEFAULT_OS_LIST = ['windows', 'linux', 'mac']

I created directories for all OS', so as to have better overview

/media/USER/DISK/Games/GOGrepo/gogrepo-library-Windows
/media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux
/media/USER/DISK/Games/GOGrepo/gogrepo-library-Mac

I've run both ./gogrepo.py update -os windows linux mac and ./gogrepo update (which should do the same now, due to my editing the gogrepo.py file) to get all OS' in the manifest.
To download all Linux files to the -Linux directory, I ran ./gogrepo.py download -os linux /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux

However, I get an error when trying to download this way.

§ ./gogrepo.py download -os linux /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux/
usage: gogrepo.py [-h] [-v]
                  {login,update,download,import,backup,verify,clean} ...
gogrepo.py: error: unrecognized arguments: -os /media/USER/DISK/Games/GOGrepo/gogrepo-library-Linux/

What am I doing wrong?


Also, on that note, I'd like to suggest, if possible, to have the download automatically create directories based on operating system.
E.g. (very crude, but you get the picture)

divinity_original_sin/
windows/
---setup_divinity_original_sin.exe
linux/
---setup_divinity_original_sin.sh
mac/
---setup_divinity_original_sin.dmg
@buhund buhund changed the title Download OS specific files only to specified directory Error when trying to download OS specific files only to specified directory Mar 18, 2018
@eddie3
Copy link
Owner

eddie3 commented Jul 19, 2022

Will add better support here in upcoming versions. Currently download does not support specifying an OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants