Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API pass-through endpoint for diffs #8

Closed
Mr0grog opened this issue Feb 23, 2017 · 1 comment
Closed

Add API pass-through endpoint for diffs #8

Mr0grog opened this issue Feb 23, 2017 · 1 comment

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Feb 23, 2017

We probably want to eventually have a more nuanced way to calculate diffs (see also: “scraping notes” on edgi-govdata-archiving/versionista-outputter#4 (comment)). This should probably be a separate service and should be configurable pluggable.

See also https://github.com/edgi-govdata-archiving/differ

@Mr0grog
Copy link
Member Author

Mr0grog commented May 16, 2017

From @danielballan on #42:

web-monitoring-db will broker responses from "diffing services"

  • diff/start..end/ -> UNIX-style diff
  • diff/start..end/pf -> PageFreezer JSON response
  • maybe temporarily support diff/start..end/versionista but only versionista-source pages would support that

Response formatted as JSON. Maybe support richer types later.

{'page_id': ...,
 'version_id', ...,
 'diff_service': ...,
 'diff_service_version': ...,
 'content': VERBATIM_RESPONSE_FROM_DIFFING_SERVICE}

@Mr0grog Mr0grog changed the title Make diffing service pluggable Add API pass-through endpoint for diffs May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant