Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notification sent for every subscriber to every other subscriber #182

Open
binarymist opened this issue Mar 13, 2018 · 5 comments
Open

Comments

@binarymist
Copy link
Contributor

binarymist commented Mar 13, 2018

Here is the scenario:

I have a blog post: https://binarymist.io/blog/2018/02/24/hugo-with-staticman-commenting-and-subscriptions/

At the time of submitting this, there are three commenters, of which all have subscribed.
When any one of the existing commenters including myself submits a comment and I accept the github pull request, each of the existing two commenters/subscribers, are sent two email notifications for every new comment and I am sent three email notifications for the same.

Do we have any idea what is causing this behaviour @eduardoboucas?

@binarymist
Copy link
Contributor Author

I notice that Staticman processEntry and processMerge both send the email notification, is this the fault or maybe something else. Let me know if you need help replicating or testing?

@binarymist
Copy link
Contributor Author

Any progress with this @eduardoboucas?

@binarymist
Copy link
Contributor Author

Is no one else having this issue @eduardoboucas?

@binarymist
Copy link
Contributor Author

I've recently upgraded to v3 bsed on #243, and it seems that the duplicates are not happening.

@binarymist
Copy link
Contributor Author

Did I speak too soon? #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant