Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repos with setup.py changes for package extras #386

Open
1 task done
rgraber opened this issue Aug 7, 2023 · 6 comments
Open
1 task done

Update repos with setup.py changes for package extras #386

rgraber opened this issue Aug 7, 2023 · 6 comments
Assignees

Comments

@rgraber
Copy link
Contributor

rgraber commented Aug 7, 2023

openedx/edx-cookiecutters#377 and openedx/edx-cookiecutters#379 made changes to setup.py in cookiecutters to improve the handling of package extras. We should run the update script against all our package repositories to pick up the change.

Before updating:

  • Double-check that extras are allowed in constraints files
    • It seems that some versions of pip don't like it, but that's OK -- pip-tools doesn't seem to mind, and that's all that should ever be looking at the constraints file.
@timmc-edx
Copy link
Member

I think there might be some more tweaks to make first—see this old comment about commas: openedx/edx-cookiecutters#154

(I might go ahead and make a PR for that.)

@jmbowman
Copy link

jmbowman commented Aug 9, 2023

Tim plans to make a fix to the script, then pass along to Arbi-BOM to run across the repos.

@timmc-edx
Copy link
Member

timmc-edx commented Aug 14, 2023

PR for adding better extras support, although at the moment it's not as well tested as I would like: openedx/edx-cookiecutters#379

[EDIT] Done.

@timmc-edx timmc-edx changed the title Run update_setup_py on all package repositories Update repos with setup.py changes for package extras Aug 17, 2023
@timmc-edx
Copy link
Member

Ready for Arbi-BOM to pick up.

@zubairshakoorarbisoft
Copy link
Contributor

Hi @timmc-edx , Can you please review this testing PR? I've just run a script on one repo(for testing). Is everything looks good? If so I can run bulk job to do this in all the repos.

This was referenced Sep 6, 2023
@robrap
Copy link
Contributor

robrap commented Jan 26, 2024

@timmc-edx @iamsobanjaved: This ticket is marked "Done" on the arch-bom board, and in "Author Team Review" on the Arbi-BOM board. If it is Done for everyone, please close the issue. If it is done for arch-bom, but not for arbi-bom, maybe arch-bom should just remove it from our board?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Author Team Review
Archived in project
Development

No branches or pull requests

5 participants