Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate currentlySupportedLangs.jsx dynamically | FC-0012 #389

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Feb 2, 2024

Changes

Generate the list of languages, instead of hardcoded transifex_langs = "ar,fr,es_419,zh_CN" in Makefile.

Now it generates the file based on the atlas pull result.

This pull request is extracted from the deprecation PR below:

We plan to rebase the other PR once this PR is merged to make it a deprecation-only PR.

Testing instructions

Run the following command:

$ make OPENEDX_ATLAS_PULL=yes pull_translations
$ nvm use 16
$ npm ci
$ npm run build  # Check for build errors if exists

A sanity check for the generated src/i18n/messages/currentlySupportedLangs.jsx can be useful.

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 2, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd5375f) 99.16% compared to head (7b2596a) 99.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   99.16%   99.18%   +0.01%     
==========================================
  Files          74       75       +1     
  Lines        1674     1713      +39     
  Branches      413      416       +3     
==========================================
+ Hits         1660     1699      +39     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmarIthawi OmarIthawi force-pushed the dynamic-lang-list branch 3 times, most recently from d6fdecb to 4c52228 Compare February 2, 2024 18:49
@OmarIthawi OmarIthawi changed the title chore: generate currentlySupportedLangs.jsx dynamically | FC-0012 feat: generate currentlySupportedLangs.jsx dynamically | FC-0012 Feb 2, 2024
@OmarIthawi OmarIthawi force-pushed the dynamic-lang-list branch 3 times, most recently from 5af01a9 to bf4ba4d Compare February 2, 2024 19:17
instead of hardcoded `transifex_langs = "ar,fr,es_419,zh_CN"`

now it generates the file based on the `atlas pull` result
@brian-smith-tcril
Copy link
Contributor

@jristau1984 you are listed as "please inform" for this repo on the spreadsheet. I plan on merging this shortly.

@brian-smith-tcril brian-smith-tcril merged commit 500ae54 into openedx:master Feb 5, 2024
6 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants