Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System namespace not included in new migrations #69

Closed
GunnerGuyven opened this issue Mar 31, 2021 · 1 comment · Fixed by #70
Closed

System namespace not included in new migrations #69

GunnerGuyven opened this issue Mar 31, 2021 · 1 comment · Fixed by #70
Assignees
@simon-reynolds
Labels
bug

Comments

@GunnerGuyven
Copy link

GunnerGuyven commented Mar 31, 2021 •
edited
Loading

Describe the bug
open System is not included in new migrations. This results in uses of Nullable, DateTime, and other common types to lack definition references and compilation to fail.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new migration for database that has any instance of a non-required field anywhere (so that Nullable type will be included).
  2. Attempt to apply migration to database
  3. Observe failure due to uncompilable code generated in migration step

Expected behavior
open System should be included in any autogenerated file that requires the System namespace to compile.

Additional context
This bug affects version 5.0.3-alpha2
@simon-reynolds simon-reynolds self-assigned this Mar 31, 2021
@simon-reynolds simon-reynolds mentioned this issue Mar 31, 2021
Merged
6 tasks
@simon-reynolds
Copy link
Collaborator

5.0.3-alpha3 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simon-reynolds simon-reynolds

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always include System namespace in generated Migrations efcore/EFCore.FSharp
2 participants
@GunnerGuyven @simon-reynolds