Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when payment is ETH - add payment id to data field #71

Closed
ligi opened this issue Jul 19, 2019 · 3 comments
Closed

when payment is ETH - add payment id to data field #71

ligi opened this issue Jul 19, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@ligi
Copy link
Member

ligi commented Jul 19, 2019

unfortunately this is only possible for native tokens like ETH, xDAI and such - it is not possible for ERC-20
@ligi ligi added the enhancement New feature or request label Jul 19, 2019
@ligi
Copy link
Member Author

ligi commented Jul 19, 2019

perhaps also as an option (opt out)
something like this [ ] save some gas (WARNING: only do this if you really know what you are doing and are sure your amount is never rounded

@ligi
Copy link
Member Author

ligi commented Aug 6, 2019

seems this could already solve a big chunk of the rounding problems. For DAI rounding seems to happen really rarely: only 2 instances so far as far as I see:
https://etherscan.io/tokentxns?a=0x6A1517622feB74A242e68a26F423aE38E020a0b1

for ETH way more:

https://etherscan.io/address/0x6A1517622feB74A242e68a26F423aE38E020a0b1

@ligi
Copy link
Member Author

ligi commented Feb 20, 2020

obsolete after #64

@ligi ligi closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ligi