Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use TS_NODE_TYPE_CHECK insteadof TS_NODE_TRANSPILE #266

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Apr 29, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
egg-bin ✅ Ready (Inspect) Visit Preview Apr 29, 2024 11:16am

Copy link

coderabbitai bot commented Apr 29, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@killagu killagu merged commit 735cc2f into 5.x Apr 29, 2024
5 of 13 checks passed
@killagu killagu deleted the fix/dal_gen_typing branch April 29, 2024 11:17
fengmk2 pushed a commit that referenced this pull request Apr 29, 2024
[skip ci]

## [5.18.1](v5.18.0...v5.18.1) (2024-04-29)

### Bug Fixes

* use TS_NODE_TYPE_CHECK insteadof TS_NODE_TRANSPILE ([#266](#266)) ([735cc2f](735cc2f))
@fengmk2
Copy link
Member

fengmk2 commented Apr 29, 2024

@coderabbitai 提交一个 issue 跟进将此功能合并到 master 分支

Copy link

coderabbitai bot commented Apr 29, 2024

Tip

For best results, initiate chat on the files or code changes.

@fengmk2, I have successfully created an issue to track the merging of the feature into the master branch. You can view and manage the issue here: GitHub Issue #267.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Create a GitHub issue to track the merging of the feature into the master branch.
gh issue create --title "Track merging of TS_NODE_TYPE_CHECK feature into master" --body "This issue is to track the progress of merging the feature introduced in PR https://github.com/eggjs/egg-bin/pull/266, which involves using TS_NODE_TYPE_CHECK instead of TS_NODE_TRANSPILE, into the master branch."

Length of output: 349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants