Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way swtich to urllib.HttpClient2 in egg? #2467

Closed
dsonet opened this issue Apr 26, 2018 · 3 comments · Fixed by #3606
Closed

Is there a way swtich to urllib.HttpClient2 in egg? #2467

dsonet opened this issue Apr 26, 2018 · 3 comments · Fixed by #3606
Assignees
@fengmk2
Labels
Inactive

Comments

@dsonet
Copy link
Contributor

dsonet commented Apr 26, 2018 •
edited
Loading

I need the retry ability which is available in HttpClient2, but seems egg-core still use HttpClient, what's the best way to figure it out?
Maybe we should just use the HtttpClient2 since it's completely compatible with HtttpClient and introduce some very useful abilities.
@popomore popomore reopened this May 17, 2018
@atian25
Copy link
Member

atian25 commented Sep 3, 2018

ping @dead-horse

@fghpdf
Copy link

fghpdf commented Dec 28, 2018

How about this?

I used content to realize retry feature.

@popomore
Copy link
Member

popomore commented Mar 6, 2019

Can we enable it by default, it's a compatible feature. cc @fengmk2

@atian25 atian25 mentioned this issue Apr 10, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
Inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch httpclient to httpclient2 for retry feature eggjs/egg
6 participants
@fengmk2 @atian25 @popomore @dsonet @fghpdf @egg-bot