From e66c912d30bfe82167de9422c10b29faa244e067 Mon Sep 17 00:00:00 2001
From: ashish-egov <137176738+ashish-egov@users.noreply.github.com>
Date: Tue, 18 Jun 2024 11:11:23 +0530
Subject: [PATCH] Update campaignMappingUtils.ts (#925)

* Update campaignMappingUtils.ts

* Refactored
---
 .../src/server/utils/campaignMappingUtils.ts               | 7 +++++--
 .../src/server/validators/genericValidator.ts              | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/utilities/project-factory/src/server/utils/campaignMappingUtils.ts b/utilities/project-factory/src/server/utils/campaignMappingUtils.ts
index 32c4ad573cc..2dae20ea1fb 100644
--- a/utilities/project-factory/src/server/utils/campaignMappingUtils.ts
+++ b/utilities/project-factory/src/server/utils/campaignMappingUtils.ts
@@ -107,14 +107,14 @@ async function getProjectMappingBody(messageObject: any, boundaryWithProject: an
         if (boundaryWithProject[key]) {
             const resources: any[] = [];
             const pvarIds = getPvarIds(messageObject);
-            if (pvarIds) {
+            if (pvarIds && Array.isArray(pvarIds) && pvarIds.length > 0) {
                 resources.push({
                     type: "resource",
                     resourceIds: pvarIds
                 })
             }
             for (const type of Object.keys(boundaryCodes)) {
-                if (boundaryCodes[type][key]) {
+                if (boundaryCodes[type][key] && Array.isArray(boundaryCodes[type][key]) && boundaryCodes[type][key].length > 0) {
                     resources.push({
                         type: type == "user" ? "staff" : type,
                         resourceIds: [...boundaryCodes[type][key]]
@@ -143,9 +143,12 @@ async function fetchAndMap(resources: any[], messageObject: any) {
     const boundaryCodes: any = {};
 
     await enrichBoundaryCodes(resources, messageObject, boundaryCodes, sheetName);
+    logger.info("boundaryCodes : " + JSON.stringify(boundaryCodes));
     var boundaryWithProject: any = {};
     await enrichBoundaryWithProject(messageObject, boundaryWithProject, boundaryCodes);
+    logger.info("boundaryWithProject : " + JSON.stringify(boundaryWithProject));
     const projectMappingBody = await getProjectMappingBody(messageObject, boundaryWithProject, boundaryCodes);
+    logger.info("projectMappingBody : " + JSON.stringify(projectMappingBody));
     logger.info("projectMapping started ");
     const projectMappingResponse: any = await createCampaignService(projectMappingBody);
     logger.info("Project Mapping Response received");
diff --git a/utilities/project-factory/src/server/validators/genericValidator.ts b/utilities/project-factory/src/server/validators/genericValidator.ts
index 4dded7131ed..bc19d3a369b 100644
--- a/utilities/project-factory/src/server/validators/genericValidator.ts
+++ b/utilities/project-factory/src/server/validators/genericValidator.ts
@@ -200,7 +200,7 @@ async function validateProjectResource(requestBody: any) {
                     throwError("COMMON", 400, "VALIDATION_ERROR", "Enter Type In Resources");
                 }
                 if (!resourceId) {
-                    throwError("COMMON", 400, "VALIDATION_ERROR", "Enter ResourceId In Resources");
+                    throwError("COMMON", 400, "VALIDATION_ERROR", "Enter ResourceId In Resources of type " + type);
                 }
                 // Validate the resource ID based on its type
                 // await validateResourceId(type, resourceId, requestBody);