-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url fetching corrected #1320
base: master
Are you sure you want to change the base?
url fetching corrected #1320
Conversation
Warning Rate limit exceeded@suryansh-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 37 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js (2)
5-5
: Consider replacing console log with a proper logging mechanism.While useful for debugging,
console.log
statements should be removed or replaced with a more robust logging mechanism in production code to avoid cluttering the console.
9-9
: Consider replacing console log with a proper logging mechanism.The
console.log
statement is useful for debugging but should be replaced with a more robust logging mechanism in production environments.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js (1 hunks)
Additional context used
Path-based instructions (1)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js (1)
Pattern
**/*.js
: check
Additional comments not posted (2)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js (2)
4-4
: Correction of configuration key typo is appropriate.The typo in the configuration key has been corrected from
"PROJECT_SEERVICE_PATH"
to"PROJECT_SERVICE_PATH"
, ensuring the correct retrieval of the configuration value.
6-8
: URL standardization logic is correct.The logic to ensure the URL starts with a forward slash is appropriate and enhances the robustness of the URL construction.
const url = window.globalConfigs?.getConfig("PROJECT_SEERVICE_PATH") || `/health-project`; | ||
|
||
// Return the constructed URL. | ||
let url = window.globalConfigs?.getConfig("PROJECT_SERVICE_PATH") || `/health-project`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u always assume it wont be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/health-project
; change to health-project
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/getProjectServiceUrl.js
url fetching corrected