Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS version upgrade #224

Merged
merged 1 commit into from
Mar 21, 2024
Merged

CSS version upgrade #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions micro-ui/web/micro-ui-internals/packages/css/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ frontend/micro-ui/web/public/index.html
### Changelog

```bash
1.8.1-beta.5 Added CSS for Tab InboxSearchComposer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the changelog entry for 1.8.1-beta.5 is clear and follows the established format. However, consider performing a spelling and grammar check across the document to ensure professionalism and clarity in the documentation.

- This Package is more specific to DIGIT-UI's can be used across mission's
+ This package is more specific to DIGIT-UI and can be used across missions.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
1.8.1-beta.5 Added CSS for Tab InboxSearchComposer

1.8.1-beta.2 Added CSS for create hierarchy
1.8.1-beta.1 Republished after merging with Master due to version issues.
1.8.0-beta.20 Added css for info message in localisation screen
Comment on lines 42 to 48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [84-84]

Please remove the duplicated phrase "DIGIT Frontend" to enhance the clarity of the documentation.

- ### Published from DIGIT Frontend DIGIT Frontend Repo
+ ### Published from DIGIT Frontend Repo

Expand Down
2 changes: 1 addition & 1 deletion micro-ui/web/micro-ui-internals/packages/css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@egovernments/digit-ui-css",
"version": "1.8.1-beta.4",
"version": "1.8.1-beta.5",
"license": "MIT",
"main": "dist/index.css",
"author": "Jagankumar <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion micro-ui/web/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<link
href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:wght@400;500;700&family=Roboto:wght@400;500;700&display=swap"
rel="stylesheet" type="text/css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].4/dist/index.css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].5/dist/index.css" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#00bcd1" />
<title>DIGIT</title>
Expand Down