download filename fixes

[nabeelmd-eGov]

• download button fixes in summary
• download filename with custom name changes added

[coderabbitai]

Walkthrough

Walkthrough

The updates primarily focus on enhancing file download functionality across several components by integrating a new utility function, downloadExcelWithCustomName, to customize downloaded Excel file names. Additionally, minor adjustments were made to property names and value assignments to ensure consistency and accuracy within the codebase.

Changes

File Path	Change Summary
.../CampaignDocumentsPreview.js	Added import for downloadExcelWithCustomName and updated file download logic to use this new function with custom filename logic.
.../CampaignResourceDocuments.js	Updated type property assignment to a fixed value "userCredential".
.../CampaignSummary.js	Imported downloadExcelWithCustomName and refactored downloadUserCred function to utilize it for custom filename downloads.
.../UploadData.js	Refactored file download logic to use downloadExcelWithCustomName instead of setting window.location.href directly.
.../XlsPreview.js	Changed property access from file?.fileName to file?.filename.
.../utils/downloadExcel.js	Introduced downloadExcelWithCustomName function for downloading Excel files with custom names.
.../utils/index.js	Added import and export for downloadExcelWithCustomName and reorganized export statements.

🐰

In the land of code, where functions dance,
A change was made to enhance our chance.
Files now download with names so fine,
Custom titles, a feature divine.
With downloadExcelWithCustomName in play,
Our campaigns shine in a brand new way.

~ CodeRabbit

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Outside diff range and nitpick comments (4)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignDocumentsPreview.js (1)

Line range hint 28-63: The implementation of downloadExcelWithCustomName enhances the download functionality. However, ensure that the onClick event handlers are paired with appropriate keyboard event handlers for accessibility.

- <div onClick={() => setShowPreview(true)}>
+ <div onClick={() => setShowPreview(true)} onKeyPress={() => setShowPreview(true)} tabIndex="0">

Also, avoid using array indices as keys in React lists to prevent potential issues during re-renders.

- <div key={index} style={{ marginRight: "1rem" }}>
+ <div key={document.id} style={{ marginRight: "1rem" }}>

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignSummary.js (1)

Line range hint 383-403: The implementation of downloadExcelWithCustomName in downloadUserCred is correctly done. However, ensure that all onClick event handlers are paired with appropriate keyboard event handlers for accessibility.

- <div className="campaign-preview-edit-container" onClick={() => handleRedirect(1)}>
+ <div className="campaign-preview-edit-container" onClick={() => handleRedirect(1)} onKeyPress={() => handleRedirect(1)} tabIndex="0">

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (2)

Line range hint 72-87: Optimize variable declarations and avoid using the delete operator.

- var newSchema = { ...schema };
- var newProp = {};
+ let newSchema = { ...schema };
+ let newProp = {};

- delete newSchema.unique;
+ // Consider handling 'unique' property differently if it's not needed.

Also applies to: 85-85

---

Line range hint 254-254: Use strict equality checks to avoid type coercion issues.

- if (filteredData.length == 0) {
+ if (filteredData.length === 0) {
- if (targetValue <= 0 || targetValue >= 100000000) {
+ if (targetValue <= 0 || targetValue >= 100000000) {
- if (jsonData.length == 0) {
+ if (jsonData.length === 0) {
- if (fileData && fileData?.[0]?.url) {
+ if (fileData && fileData?.[0]?.url) {
- if (fileData?.[0]?.id) {
+ if (fileData?.[0]?.id) {

Also applies to: 361-361, 361-361, 473-473, 479-479, 710-710

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7b67ba9 and 504c94a.

Files selected for processing (7)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignDocumentsPreview.js (3 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignResourceDocuments.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignSummary.js (3 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (4 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/XlsPreview.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/downloadExcel.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/index.js (1 hunks)

Additional Context Used

Biome (47)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignDocumentsPreview.js (3)

40-40: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

16-16: This let declares a variable that is only assigned once.

---

39-39: Avoid using the index of an array as key property in an element.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignResourceDocuments.js (1)

11-11: Do not use template literals if interpolation and special-character handling are not needed.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignSummary.js (20)

14-35: Prefer for...of instead of forEach.

---

44-64: Prefer for...of instead of forEach.

---

126-126: Do not use template literals if interpolation and special-character handling are not needed.

---

177-177: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

178-178: Do not use template literals if interpolation and special-character handling are not needed.

---

214-214: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

215-215: Do not use template literals if interpolation and special-character handling are not needed.

---

234-234: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

235-235: Do not use template literals if interpolation and special-character handling are not needed.

---

254-254: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

255-255: Do not use template literals if interpolation and special-character handling are not needed.

---

285-285: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

286-286: Do not use template literals if interpolation and special-character handling are not needed.

---

294-294: Unsafe usage of optional chaining.

---

300-300: Unsafe usage of optional chaining.

---

307-307: Unsafe usage of optional chaining.

---

314-314: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

315-315: Do not use template literals if interpolation and special-character handling are not needed.

---

334-334: Unnecessary use of boolean literals in conditional expression.

---

390-390: Do not use template literals if interpolation and special-character handling are not needed.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (20)

85-85: Avoid the delete operator which can impact performance.

---

232-239: This else clause can be omitted because previous branches break early.

---

254-254: Use === instead of ==.
== is only allowed when comparing against null

---

361-361: Use === instead of ==.
== is only allowed when comparing against null

---

361-361: Use !== instead of !=.
!= is only allowed when comparing against null

---

460-469: This var should be declared at the root of the enclosing function.

---

463-465: Prefer for...of instead of forEach.

---

473-473: Use === instead of ==.
== is only allowed when comparing against null

---

479-479: Use === instead of ==.
== is only allowed when comparing against null

---

545-545: Change to an optional chain.

---

582-617: This else clause can be omitted because previous branches break early.

---

588-616: This else clause can be omitted because previous branches break early.

---

625-653: This else clause can be omitted because previous branches break early.

---

710-710: Use === instead of ==.
== is only allowed when comparing against null

---

727-727: Change to an optional chain.

---

52-52: This hook does not specify all of its dependencies: onSelect

---

52-52: This hook does not specify all of its dependencies: type

---

72-87: Use let or const instead of var.

---

73-73: Use let or const instead of var.

---

74-74: Use let or const instead of var.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/XlsPreview.js (1)

9-9: Alternative text title element cannot be empty

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/downloadExcel.js (2)

18-18: Template literals are preferred over string concatenation.

---

32-32: The computed expression can be simplified without the use of a string literal.

Path-based Instructions (7)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/index.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignResourceDocuments.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/downloadExcel.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/XlsPreview.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignDocumentsPreview.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignSummary.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Pattern **/*.js: check

Additional comments not posted (4)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/utils/index.js (1)

2-2: The import and export of downloadExcelWithCustomName along with the PRIMARY_COLOR constant are correctly implemented.

Also applies to: 5-6

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignResourceDocuments.js (1)

33-33: The change to assign a fixed value "userCredential" to the type property simplifies the component logic. Ensure this change is reflected wherever the type is utilized.

Verification successful

---

The change to assign a fixed value "userCredential" to the type property in CampaignResourceDocuments.js appears to be isolated to this file. There are no dynamic dependencies or other usages of the type property within this file that would be affected by this change.

• The fixed value "userCredential" is only used within CampaignResourceDocuments.js.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the impact of changing `type` to a fixed value in other components.

# Test: Search for the usage of `type` property from `CampaignResourceDocuments`. Expect: Consistent usage of the new fixed value.
rg --type javascript $'type: "userCredential"'

Length of output: 82

---

---

Script:

#!/bin/bash
# Description: Verify the impact of changing `type` to a fixed value in other components.

# Test: Search for the usage of `type` property from `CampaignResourceDocuments`. Expect: Consistent usage of the new fixed value.
rg 'type: "userCredential"' --glob '*.js'

Length of output: 187

---

---

Script:

#!/bin/bash
# Description: Verify the usage of the `type` property in the codebase to ensure no dynamic dependencies are affected.

# Test: Search for the usage of the `type` property in JavaScript files.
rg 'type:' --glob '*.js'

Length of output: 21682

---

---

Script:

#!/bin/bash
# Description: Verify the usage of the `type` property within CampaignResourceDocuments.js to ensure no dynamic dependencies are affected.

# Test: Search for the usage of the `type` property within CampaignResourceDocuments.js.
rg 'type:' micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignResourceDocuments.js

Length of output: 154

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/XlsPreview.js (1)

23-23: The update from file?.fileName to file?.filename aligns with standard JavaScript property naming conventions. Ensure all references to this property are updated accordingly.

Verification successful

The previous script failed due to an incorrect file type specification in rg. Let's correct this and re-run the search to ensure the correct usage of file?.filename across the codebase.

---

The search results confirm that there are no occurrences of file?.fileName and that file?.filename is used in BulkUpload.js. This indicates that the change in XlsPreview.js is consistent with the usage in other components.

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BulkUpload.js: file.filename

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the usage of `file?.filename` in other components.

# Test: Search for the usage of `file?.fileName`. Expect: No occurrences, only `file?.filename` should be used.
rg --type javascript $'file?.fileName'

Length of output: 74

---

---

Script:

#!/bin/bash
# Description: Verify the usage of `file?.filename` in other components.

# Test: Search for the usage of `file?.fileName`. Expect: No occurrences, only `file?.filename` should be used.
rg 'file?.fileName'

# Test: Search for the usage of `file?.filename`. Expect: Occurrences in relevant components.
rg 'file?.filename'

Length of output: 245

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

12-12: Ensure the new import downloadExcelWithCustomName is utilized correctly throughout the file.

[coderabbitai]

Use optional chaining consistently to ensure robustness.

- const fileNameWithoutExtension = file?.filename.split(/\.(xlsx|xls)/)[0];
+ const fileNameWithoutExtension = file?.filename?.split(/\.(xlsx|xls)/)[0];
- downloadExcelWithCustomName({ fileStoreId: fileData?.[0]?.id, customName: fileData?.[0]?.filename });
+ downloadExcelWithCustomName({ fileStoreId: fileData?.[0]?.id, customName: fileData?.[0]?.filename });

Also applies to: 727-727

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	if (file && file?.url) {
	if (file && file?.url) {
	const fileNameWithoutExtension = file?.filename?.split(/\.(xlsx|xls)/)[0];
	downloadExcelWithCustomName({ fileStoreId: fileData?.[0]?.id, customName: fileData?.[0]?.filename });
	}

[coderabbitai]

Use template literals for better readability in string concatenation.

- link.download = fileName + ".xlsx";
+ link.download = `${fileName}.xlsx`;

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	link.download = fileName + ".xlsx";
	link.download = `${fileName}.xlsx`;

[coderabbitai]

Simplify the access token retrieval.

- "auth-token": Digit.UserService.getUser()?.["access_token"],
+ "auth-token": Digit.UserService.getUser()?.accessToken,

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	"auth-token": Digit.UserService.getUser()?.["access_token"],
	"auth-token": Digit.UserService.getUser()?.accessToken,