HLM-6225_added time out according to data

[Bhavya-egov]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes introduce a new data retrieval mechanism using useCustomMDMS for baseTimeOut within the UploadData.js component. Additionally, a new baseTimeOut.js file defines a constant for baseTimeOut. The useResourceData function is updated to handle Excel files with Axios and XLSX libraries, incorporating logic for retry intervals based on data length.

Changes

Files	Change Summary
.../campaign-manager/src/components/UploadData.js	Added useCustomMDMS for baseTimeOut retrieval and updated useResourceData to include baseTimeOut.
.../campaign-manager/src/configs/baseTimeOut.js	Introduced a new file defining and exporting a constant baseTimeOut with a value of 100.
.../campaign-manager/src/hooks/useResourceData.js	Enhanced useResourceData with Excel file handling using Axios and XLSX, and adjusted retry intervals.

Sequence Diagram(s)

sequenceDiagram
    participant UploadData.js
    participant useCustomMDMS
    participant baseTimeOut.js
    participant useResourceData.js
    participant API

    UploadData.js->>useCustomMDMS: Retrieve baseTimeOut
    useCustomMDMS-->>UploadData.js: Return baseTimeOut data
    UploadData.js->>baseTimeOut.js: Import baseTimeOut constant
    UploadData.js->>useResourceData.js: Call useResourceData with baseTimeOut
    useResourceData.js->>API: Handle Excel file with Axios and XLSX
    API-->>useResourceData.js: Return processed data
    useResourceData.js-->>UploadData.js: Return final data

Loading

Poem

In the realm of code so bright,
baseTimeOut takes its flight,
From UploadData to Excel's might,
With Axios and retries, just right.
In the digital dance, we delight,
A rabbit's joy, in every byte!
🐇✨📊

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Outside diff range and nitpick comments (2)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js (1)

8-8: Variable jsonDataLength is declared but not used until much later in the code. Consider declaring it closer to its first use to improve readability.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Line range hint 922-922: Consider using optional chaining to safely access deeply nested properties. This can prevent potential runtime errors if some intermediate properties are undefined.

- const errorMessage = temp?.error.replaceAll(":", "-");
+ const errorMessage = temp?.error?.replaceAll(":", "-");

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c442ba4 and 45a1c42.

Files selected for processing (3)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (2 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/baseTimeOut.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js (5 hunks)

Files skipped from review due to trivial changes (1)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/baseTimeOut.js

Additional context used

Path-based instructions (2)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Pattern **/*.js: check

Biome

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js

[error] 9-9: Do not shadow the global "Error" property. (lint/suspicious/noShadowRestrictedNames)

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

---

[error] 63-63: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

---

[error] 70-74: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js

[error] 94-94: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 142-142: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 159-159: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 316-323: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 391-393: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 550-559: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 701-701: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

---

[error] 739-774: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 745-773: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 782-810: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 922-922: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

---

[error] 1069-1069: The comma operator is disallowed. (lint/style/noCommaOperator)

Its use is often confusing and obscures side effects.

---

[error] 1040-1040: Avoid passing children using a prop (lint/correctness/noChildrenProp)

The canonical way to pass children in React is to use JSX elements

---

[error] 1041-1041: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

---

[error] 1053-1061: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

---

[error] 1062-1071: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

Additional comments not posted (5)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js (3)

4-4: The function signature of useResourceData has been updated to include baseTimeOut as a parameter. Ensure that all calls to this function are updated to pass this new parameter.

---

80-82: The calculation of retryInterval based on baseTimeOut and jsonDataLength is a good use of dynamic timing for operations. However, ensure that jsonDataLength is always properly set before this calculation to avoid runtime errors.

---

99-100: Doubling the retryInterval on each iteration without a maximum limit can lead to very long wait times. Consider implementing a maximum retry interval.
[REFACTOR_SUGGESTion]

+ const maxRetryInterval = 30000; // 30 seconds as maximum retry interval
  retryInterval *= 2;
+ retryInterval = Math.min(retryInterval, maxRetryInterval);

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (2)

51-51: The use of useCustomMDMS to fetch baseTimeOut configuration is a good integration. Ensure that the baseTimeOut configuration is always available and correctly formatted in the MDMS to prevent runtime errors.

---

715-715: The integration of baseTimeOut into the useResourceData function call is correctly implemented. Ensure that the baseTimeOut data structure is always consistent as expected here.

[coderabbitai]

The variable name Error shadows a global property. Consider renaming it to avoid confusion and potential bugs.

- let Error = {
+ let errorDetails = {

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	let Error = {
	let errorDetails = {

Tools

Biome

[error] 9-9: Do not shadow the global "Error" property. (lint/suspicious/noShadowRestrictedNames)

Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.

[coderabbitai]

Proper error handling is implemented by checking the isError property of the response. However, consider adding more detailed logging or error tracking for better debugging and maintenance.

+ console.error("Validation error:", errorMessage);

Also applies to: 722-722

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	setIsValidation(false);
	setIsValidation(false);
	console.error("Validation error:", errorMessage);