Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ENS names (with vnd.github as per EIP-634) as usernames #7

Open
axic opened this issue Dec 3, 2019 · 1 comment
Open

Support ENS names (with vnd.github as per EIP-634) as usernames #7

axic opened this issue Dec 3, 2019 · 1 comment

Comments

@axic
Copy link
Contributor

axic commented Dec 3, 2019 •
edited
Loading

ethereum/EIPs#2400 (comment) attempted to do that, but obviously the automerger has no support for it.

It would be nice though and there seem to be specifications to cover it: https://eips.ethereum.org/EIPS/eip-634

The automerger should attempt to read the vnd.github text record (baed on EIP-634) of an ENS name and compare the github username included in there to the author/approver of the PR.
@axic axic mentioned this issue Dec 16, 2019
Closed
@3esmit
Copy link

3esmit commented Dec 20, 2019

I think is interesting using ENS usernames. The messages could be signed with the resolving pubkey defined in the ENS name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axic @3esmit