Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Instrumentation Scope on all signals #325

Open
Mpdreamz opened this issue Jul 19, 2024 · 1 comment
Open

Support Instrumentation Scope on all signals #325

Mpdreamz opened this issue Jul 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Mpdreamz
Copy link
Member

We currently map instrumentationScope for traces as service.framework.{name|version}(

func TestInstrumentationLibrary(t *testing.T) {
traces, spans := newTracesSpans()
spans.Scope().SetName("library-name")
spans.Scope().SetVersion("1.2.3")
otelSpan := spans.Spans().AppendEmpty()
otelSpan.SetTraceID(pcommon.TraceID{1})
otelSpan.SetSpanID(pcommon.SpanID{2})
events := transformTraces(t, traces)
event := (*events)[0]
assert.Equal(t, "library-name", event.Service.Framework.Name)
assert.Equal(t, "1.2.3", event.Service.Framework.Version)
) but not for signals and logs.

This was reported here: https://discuss.elastic.co/t/logs-dotnet-logger-category-where/363304

@davidgeorgehope
Copy link

Similar issue over here I think https://github.com/elastic/sdh-apm/issues/1443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants