-
Notifications
You must be signed in to change notification settings - Fork 4.9k
/
s3_objects_test.go
313 lines (258 loc) · 9.83 KB
/
s3_objects_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
// or more contributor license agreements. Licensed under the Elastic License;
// you may not use this file except in compliance with the Elastic License.
package awss3
import (
"bytes"
"context"
"errors"
"io/ioutil"
"path/filepath"
"strings"
"testing"
awssdk "github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/s3"
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/elastic/beats/v7/libbeat/beat"
"github.com/elastic/beats/v7/libbeat/common"
"github.com/elastic/beats/v7/libbeat/logp"
)
func newS3Object(t testing.TB, filename, contentType string) (s3EventV2, *s3.GetObjectResponse) {
data, err := ioutil.ReadFile(filename)
if err != nil {
t.Fatal(err)
}
return newS3Event(filename), newS3GetObjectResponse(filename, data, contentType)
}
func newS3GetObjectResponse(filename string, data []byte, contentType string) *s3.GetObjectResponse {
r := bytes.NewReader(data)
contentLen := int64(r.Len())
resp := &s3.GetObjectResponse{
GetObjectOutput: &s3.GetObjectOutput{
Body: ioutil.NopCloser(r),
ContentLength: &contentLen,
},
}
if contentType != "" {
resp.ContentType = &contentType
}
switch strings.ToLower(filepath.Ext(filename)) {
case ".gz":
gzipEncoding := "gzip"
resp.ContentEncoding = &gzipEncoding
}
return resp
}
func TestS3ObjectProcessor(t *testing.T) {
logp.TestingSetup()
t.Run("download text/plain file", func(t *testing.T) {
testProcessS3Object(t, "testdata/log.txt", "text/plain", 2)
})
t.Run("multiline content", func(t *testing.T) {
sel := fileSelectorConfig{ReaderConfig: readerConfig{}}
sel.ReaderConfig.InitDefaults()
// Unfortunately the config structs for the parser package are not
// exported to use config parsing.
cfg := common.MustNewConfigFrom(map[string]interface{}{
"parsers": []map[string]interface{}{
{
"multiline": map[string]interface{}{
"pattern": "^<Event",
"negate": true,
"match": "after",
},
},
},
})
require.NoError(t, cfg.Unpack(&sel.ReaderConfig.Parsers))
testProcessS3Object(t, "testdata/multiline.txt", "text/plain", 2, sel)
})
t.Run("application/json content-type", func(t *testing.T) {
testProcessS3Object(t, "testdata/log.json", "application/json", 2)
})
t.Run("application/x-ndjson content-type", func(t *testing.T) {
testProcessS3Object(t, "testdata/log.ndjson", "application/x-ndjson", 2)
})
t.Run("configured content-type", func(t *testing.T) {
sel := fileSelectorConfig{ReaderConfig: readerConfig{ContentType: contentTypeJSON}}
testProcessS3Object(t, "testdata/multiline.json", "application/octet-stream", 2, sel)
})
t.Run("uncompress application/zip content", func(t *testing.T) {
testProcessS3Object(t, "testdata/multiline.json.gz", "application/json", 2)
})
t.Run("unparsable json", func(t *testing.T) {
testProcessS3ObjectError(t, "testdata/invalid.json", "application/json", 0)
})
t.Run("split array", func(t *testing.T) {
sel := fileSelectorConfig{ReaderConfig: readerConfig{ExpandEventListFromField: "Events"}}
testProcessS3Object(t, "testdata/events-array.json", "application/json", 2, sel)
})
t.Run("split array error missing key", func(t *testing.T) {
sel := fileSelectorConfig{ReaderConfig: readerConfig{ExpandEventListFromField: "Records"}}
testProcessS3ObjectError(t, "testdata/events-array.json", "application/json", 0, sel)
})
t.Run("events have a unique repeatable _id", func(t *testing.T) {
// Hash of bucket ARN, object key, object versionId, and log offset.
events := testProcessS3Object(t, "testdata/log.txt", "text/plain", 2)
const idFieldName = "@metadata._id"
for _, event := range events {
v, _ := event.GetValue(idFieldName)
if assert.NotNil(t, v, idFieldName+" is nil") {
_id, ok := v.(string)
if assert.True(t, ok, idFieldName+" is not a string") {
assert.NotEmpty(t, _id, idFieldName+" is empty")
}
}
}
})
t.Run("download error", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
ctrl, ctx := gomock.WithContext(ctx, t)
defer ctrl.Finish()
mockS3API := NewMockS3API(ctrl)
mockPublisher := NewMockBeatClient(ctrl)
s3Event := newS3Event("log.txt")
mockS3API.EXPECT().
GetObject(gomock.Any(), gomock.Eq(s3Event.S3.Bucket.Name), gomock.Eq(s3Event.S3.Object.Key)).
Return(nil, errFakeConnectivityFailure)
s3ObjProc := newS3ObjectProcessorFactory(logp.NewLogger(inputName), nil, mockS3API, mockPublisher, nil)
ack := newEventACKTracker(ctx)
err := s3ObjProc.Create(ctx, logp.NewLogger(inputName), ack, s3Event).ProcessS3Object()
require.Error(t, err)
assert.True(t, errors.Is(err, errFakeConnectivityFailure), "expected errFakeConnectivityFailure error")
})
t.Run("no error empty result in download", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
ctrl, ctx := gomock.WithContext(ctx, t)
defer ctrl.Finish()
mockS3API := NewMockS3API(ctrl)
mockPublisher := NewMockBeatClient(ctrl)
s3Event := newS3Event("log.txt")
mockS3API.EXPECT().
GetObject(gomock.Any(), gomock.Eq(s3Event.S3.Bucket.Name), gomock.Eq(s3Event.S3.Object.Key)).
Return(nil, nil)
s3ObjProc := newS3ObjectProcessorFactory(logp.NewLogger(inputName), nil, mockS3API, mockPublisher, nil)
ack := newEventACKTracker(ctx)
err := s3ObjProc.Create(ctx, logp.NewLogger(inputName), ack, s3Event).ProcessS3Object()
require.Error(t, err)
})
t.Run("no content type in GetObject response", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
ctrl, ctx := gomock.WithContext(ctx, t)
defer ctrl.Finish()
mockS3API := NewMockS3API(ctrl)
mockPublisher := NewMockBeatClient(ctrl)
s3Event, s3Resp := newS3Object(t, "testdata/log.txt", "")
var events []beat.Event
gomock.InOrder(
mockS3API.EXPECT().
GetObject(gomock.Any(), gomock.Eq(s3Event.S3.Bucket.Name), gomock.Eq(s3Event.S3.Object.Key)).
Return(s3Resp, nil),
mockPublisher.EXPECT().
Publish(gomock.Any()).
Do(func(event beat.Event) { events = append(events, event) }).
Times(2),
)
s3ObjProc := newS3ObjectProcessorFactory(logp.NewLogger(inputName), nil, mockS3API, mockPublisher, nil)
ack := newEventACKTracker(ctx)
err := s3ObjProc.Create(ctx, logp.NewLogger(inputName), ack, s3Event).ProcessS3Object()
require.NoError(t, err)
})
}
func testProcessS3Object(t testing.TB, file, contentType string, numEvents int, selectors ...fileSelectorConfig) []beat.Event {
return _testProcessS3Object(t, file, contentType, numEvents, false, selectors)
}
func testProcessS3ObjectError(t testing.TB, file, contentType string, numEvents int, selectors ...fileSelectorConfig) []beat.Event {
return _testProcessS3Object(t, file, contentType, numEvents, true, selectors)
}
func _testProcessS3Object(t testing.TB, file, contentType string, numEvents int, expectErr bool, selectors []fileSelectorConfig) []beat.Event {
t.Helper()
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
ctrl, ctx := gomock.WithContext(ctx, t)
defer ctrl.Finish()
mockS3API := NewMockS3API(ctrl)
mockPublisher := NewMockBeatClient(ctrl)
s3Event, s3Resp := newS3Object(t, file, contentType)
var events []beat.Event
gomock.InOrder(
mockS3API.EXPECT().
GetObject(gomock.Any(), gomock.Eq(s3Event.S3.Bucket.Name), gomock.Eq(s3Event.S3.Object.Key)).
Return(s3Resp, nil),
mockPublisher.EXPECT().
Publish(gomock.Any()).
Do(func(event beat.Event) { events = append(events, event) }).
Times(numEvents),
)
s3ObjProc := newS3ObjectProcessorFactory(logp.NewLogger(inputName), nil, mockS3API, mockPublisher, selectors)
ack := newEventACKTracker(ctx)
err := s3ObjProc.Create(ctx, logp.NewLogger(inputName), ack, s3Event).ProcessS3Object()
if !expectErr {
require.NoError(t, err)
assert.Equal(t, numEvents, len(events))
assert.EqualValues(t, numEvents, ack.pendingACKs)
} else {
require.Error(t, err)
}
return events
}
// TestNewMockS3Pager verifies that newMockS3Pager is behaving similar to
// the AWS S3 Pager.
func TestNewMockS3Pager(t *testing.T) {
fakeObjects := []s3.Object{
{Key: awssdk.String("foo")},
{Key: awssdk.String("bar")},
{Key: awssdk.String("baz")},
}
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
ctrl, ctx := gomock.WithContext(ctx, t)
defer ctrl.Finish()
mockS3Pager := newMockS3Pager(ctrl, 1, fakeObjects)
mockS3API := NewMockS3API(ctrl)
mockS3API.EXPECT().ListObjectsPaginator(gomock.Any(), "").Return(mockS3Pager)
// Test the mock.
var keys []string
pager := mockS3API.ListObjectsPaginator("nombre", "")
for pager.Next(ctx) {
for _, s3Obj := range pager.CurrentPage().Contents {
keys = append(keys, *s3Obj.Key)
}
}
if err := pager.Err(); err != nil {
t.Fatal(err)
}
assert.Equal(t, []string{"foo", "bar", "baz"}, keys)
}
// newMockS3Pager returns a s3Pager that paginates the given s3Objects based on
// the specified page size. It never returns an error.
func newMockS3Pager(ctrl *gomock.Controller, pageSize int, s3Objects []s3.Object) *MockS3Pager {
mockS3Pager := NewMockS3Pager(ctrl)
currentPage := -1
numPages := len(s3Objects) / pageSize
if len(s3Objects)%pageSize != 0 {
numPages++
}
mockS3Pager.EXPECT().Next(gomock.Any()).Times(numPages + 1).DoAndReturn(func(_ context.Context) interface{} {
currentPage++
next := currentPage*pageSize < len(s3Objects)
return next
})
mockS3Pager.EXPECT().CurrentPage().AnyTimes().DoAndReturn(func() *s3.ListObjectsOutput {
startIdx := currentPage * pageSize
endIdx := currentPage + 1*pageSize
if endIdx > len(s3Objects) {
endIdx = len(s3Objects)
}
return &s3.ListObjectsOutput{
Contents: s3Objects[startIdx:endIdx],
}
})
mockS3Pager.EXPECT().Err().Return(nil)
return mockS3Pager
}