From 1d16a5bb935d5482d3574113f5adaeeebc6116f5 Mon Sep 17 00:00:00 2001 From: Michal Pristas Date: Fri, 19 Feb 2021 15:27:06 +0100 Subject: [PATCH] no no-restart option --- x-pack/elastic-agent/pkg/agent/application/enroll_cmd.go | 6 ------ x-pack/elastic-agent/pkg/agent/cmd/enroll.go | 4 ---- 2 files changed, 10 deletions(-) diff --git a/x-pack/elastic-agent/pkg/agent/application/enroll_cmd.go b/x-pack/elastic-agent/pkg/agent/application/enroll_cmd.go index 82d996bd620..22d3f8625d0 100644 --- a/x-pack/elastic-agent/pkg/agent/application/enroll_cmd.go +++ b/x-pack/elastic-agent/pkg/agent/application/enroll_cmd.go @@ -84,7 +84,6 @@ type EnrollCmdOption struct { Staging string FleetServerConnStr string FleetServerPolicyID string - NoRestart bool } func (e *EnrollCmdOption) kibanaConfig() (*kibana.Config, error) { @@ -178,7 +177,6 @@ func (c *EnrollCmd) Execute(ctx context.Context) error { // enroll should use localhost as fleet-server is now running // it must also restart c.options.URL = "http://localhost:8000" - c.options.NoRestart = false } err := c.enrollWithBackoff(ctx) @@ -186,10 +184,6 @@ func (c *EnrollCmd) Execute(ctx context.Context) error { return errors.New(err, "fail to enroll") } - if c.options.NoRestart { - return nil - } - if c.daemonReload(ctx) != nil { c.log.Info("Elastic Agent might not be running; unable to trigger restart") } diff --git a/x-pack/elastic-agent/pkg/agent/cmd/enroll.go b/x-pack/elastic-agent/pkg/agent/cmd/enroll.go index 58c99306e71..cd4b12ef422 100644 --- a/x-pack/elastic-agent/pkg/agent/cmd/enroll.go +++ b/x-pack/elastic-agent/pkg/agent/cmd/enroll.go @@ -38,7 +38,6 @@ func newEnrollCommandWithArgs(flags *globalFlags, _ []string, streams *cli.IOStr addEnrollFlags(cmd) cmd.Flags().BoolP("force", "f", false, "Force overwrite the current and do not prompt for confirmation") - cmd.Flags().Bool("no-restart", false, "Skip restarting the currently running daemon") // used by install command cmd.Flags().BoolP("from-install", "", false, "Set by install command to signal this was executed from install") @@ -141,11 +140,9 @@ func enroll(streams *cli.IOStreams, cmd *cobra.Command, flags *globalFlags, args } } - noRestart, _ := cmd.Flags().GetBool("no-restart") force, _ := cmd.Flags().GetBool("force") if fromInstall { force = true - noRestart = true } // prompt only when it is not forced and is already enrolled @@ -192,7 +189,6 @@ func enroll(streams *cli.IOStreams, cmd *cobra.Command, flags *globalFlags, args Staging: staging, FleetServerConnStr: fServer, FleetServerPolicyID: fPolicy, - NoRestart: noRestart, } c, err := application.NewEnrollCmd(