From 74865c280e57f9fc6f3a9b865e446eec63493ae1 Mon Sep 17 00:00:00 2001 From: Jaime Soriano Pastor Date: Wed, 17 Feb 2021 12:49:53 +0100 Subject: [PATCH] Fix jolokia downloads in 6.8 (#24066) Backport some fixes from 7.x: * Use sonatype mirror to download jolokia (#12707) * Try to make jolokia downloads more robust (#13201) Re-enable integration tests for Metricbeat. --- metricbeat/Jenkinsfile.yml | 2 -- metricbeat/module/jolokia/_meta/Dockerfile | 20 +++++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/metricbeat/Jenkinsfile.yml b/metricbeat/Jenkinsfile.yml index c1590dfbf1a..c6a08152295 100644 --- a/metricbeat/Jenkinsfile.yml +++ b/metricbeat/Jenkinsfile.yml @@ -20,8 +20,6 @@ stages: make check-no-changes; build: make: "RACE_DETECTOR=1 make -C metricbeat check testsuite integration-tests-environment" - when: - disabled: true ## Disabled since Integration Testing is broken. See https://github.com/elastic/beats/issues/21961 crosscompile: make: "make -C metricbeat crosscompile" windows: diff --git a/metricbeat/module/jolokia/_meta/Dockerfile b/metricbeat/module/jolokia/_meta/Dockerfile index 91f2e6d284d..9eae5455d3b 100644 --- a/metricbeat/module/jolokia/_meta/Dockerfile +++ b/metricbeat/module/jolokia/_meta/Dockerfile @@ -5,22 +5,24 @@ ENV TOMCAT_VERSION 7.0.86 ENV TC apache-tomcat-${TOMCAT_VERSION} ENV JOLOKIA_VERSION 1.5.0 -RUN apk update;\ - apk add curl +RUN apk update && \ + apk add curl openssl ca-certificates bash HEALTHCHECK --interval=1s --retries=90 CMD curl -f localhost:8778/jolokia/ EXPOSE 8778 # Prepare a server where jolokia runs in proxy mode -RUN wget http://archive.apache.org/dist/tomcat/tomcat-7/v${TOMCAT_VERSION}/bin/${TC}.tar.gz;\ - tar xzf ${TC}.tar.gz -C /usr;\ - rm ${TC}.tar.gz;\ - sed -i -e 's/Connector port="8080"/Connector port="8778"/g' /usr/${TC}/conf/server.xml;\ - wget http://central.maven.org/maven2/org/jolokia/jolokia-war/${JOLOKIA_VERSION}/jolokia-war-${JOLOKIA_VERSION}.war -O /usr/${TC}/webapps/jolokia.war +RUN wget http://archive.apache.org/dist/tomcat/tomcat-7/v${TOMCAT_VERSION}/bin/${TC}.tar.gz && \ + tar xzf ${TC}.tar.gz -C /usr && \ + rm ${TC}.tar.gz && \ + sed -i -e 's/Connector port="8080"/Connector port="8778"/g' /usr/${TC}/conf/server.xml && \ + curl -J -L -s -f -o - https://github.com/kadwanev/retry/releases/download/1.0.1/retry-1.0.1.tar.gz | tar xfz - -C /usr/local/bin && \ + retry --min 1 --max 180 -- curl -J -L -s -f --show-error -o /usr/${TC}/webapps/jolokia.war \ + "https://oss.sonatype.org/content/repositories/releases/org/jolokia/jolokia-war/${JOLOKIA_VERSION}/jolokia-war-${JOLOKIA_VERSION}.war" # JMX setting to request authentication with remote connection -RUN echo "monitorRole QED" >> /usr/lib/jvm/java-1.8-openjdk/jre/lib/management/jmxremote.password;\ - echo "controlRole R&D" >> /usr/lib/jvm/java-1.8-openjdk/jre/lib/management/jmxremote.password;\ +RUN echo "monitorRole QED" >> /usr/lib/jvm/java-1.8-openjdk/jre/lib/management/jmxremote.password && \ + echo "controlRole R&D" >> /usr/lib/jvm/java-1.8-openjdk/jre/lib/management/jmxremote.password && \ chmod 600 /usr/lib/jvm/java-1.8-openjdk/jre/lib/management/jmxremote.password ADD jolokia.xml /usr/${TC}/conf/Catalina/localhost/jolokia.xml