Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerID support for non docker containers #14967

Closed
ndubss opened this issue Dec 5, 2019 · 2 comments · Fixed by #15947
Closed

ContainerID support for non docker containers #14967

ndubss opened this issue Dec 5, 2019 · 2 comments · Fixed by #15947

Comments

@ndubss
Copy link

ndubss commented Dec 5, 2019

Add_docker_metadata needs to be refactored to get containerID of non docker containers.
https://github.com/elastic/beats/blob/ce68c7814e5c34ff417701481e1f65f1d5e100cf/libbeat/processors/add_docker_metadata/add_docker_metadata.go#L257-L264

Lookup CID using process cgroup membership data can be moved to add_process_metadata
https://github.com/elastic/beats/blob/ce68c7814e5c34ff417701481e1f65f1d5e100cf/libbeat/processors/add_docker_metadata/add_docker_metadata.go#L142-L148

@vjsamuel add anything you think I've missed

@andresrc
Copy link
Contributor

Can you provide some more detail on the ask? E.g, which runtimes are you expecting to be supported? Thanks!

@vjsamuel
Copy link
Contributor

Containerd is one such use case. Under the hood it just uses systemd to create cgroups and can be seen as systemd.slice in the cgroup files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants