Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add Redis node and proxy #15269

Closed
10 tasks done
sorantis opened this issue Dec 30, 2019 · 5 comments
Closed
10 tasks done

[Metricbeat] Add Redis node and proxy #15269

sorantis opened this issue Dec 30, 2019 · 5 comments
Assignees
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0

Comments

@sorantis
Copy link
Contributor

sorantis commented Dec 30, 2019

Currently the Redis module in Metricbeat only support database metrics. In addition to db metrics Redis Enterprise exposes node and proxy metrics. We should add support for node and proxy metrics to redis module. Note that starting from v 5.0.2 Redis exposes metrics at the node, database, shard and proxy levels via a Prometheus endpoint. This could simplify further development of the redis module.

Modules

For a metricset to go GA, the following criterias should be met:

  • Supported versions are documented
  • [ ] Supported operating systems are documented (if applicable)
  • Integration tests exist
  • System tests exist
  • Automated checks that all fields are documented
  • Documentation
  • Fields follow ECS and naming conventions
  • Dashboards exists (if applicable)
  • Kibana Home Tutorial (if applicable)
    • Open PR against Kibana repo with tutorial. Examples can be found here.
  • Example data.json exists and an automated way to generate it exists (go test -data)
  • Test environment in Docker exist for integration tests
@sorantis sorantis added enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Dec 30, 2019
@sorantis sorantis changed the title [Metricbeat] Add Redis node and proxy [Metricbeat] Add Redis node and proxy metrics Dec 30, 2019
@andresrc andresrc changed the title [Metricbeat] Add Redis node and proxy metrics [Metricbeat] Add Redis node and proxy Jan 14, 2020
@andresrc andresrc added Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0 [zube]: Inbox [zube]: Ready and removed [zube]: Backlog [zube]: Inbox labels Jan 27, 2020
@mtojek
Copy link
Contributor

mtojek commented Feb 5, 2020

@sorantis

Here comes to mind similar questions to #7723 :

  1. Can we simply switch Prometheus metrics endpoint only? How can we deprecate old code?

  2. It seems that Prometheus endpoint is exposed only by the enterprise release. If we don't want to drop support for non-commercial releases, do you suggest creating metricsets supported only by the Redis Enterprise Server or a separate module?

@andresrc
Copy link
Contributor

andresrc commented Feb 5, 2020

IMHO, when possible we should keep native integration

@sorantis
Copy link
Contributor Author

sorantis commented Feb 5, 2020

See my response in #7723. TLDR; I agree with Andres - use native APIs if possible.

@mtojek
Copy link
Contributor

mtojek commented Feb 28, 2020

Checklist has been updated. I've started preparing a relevant dashboard.

@mtojek
Copy link
Contributor

mtojek commented Mar 4, 2020

Resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Development

No branches or pull requests

3 participants