Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ingress_controller fields mapping from text to keyword #17834

Closed
sejbot opened this issue Apr 20, 2020 · 4 comments · Fixed by #17978
Closed

Change ingress_controller fields mapping from text to keyword #17834

sejbot opened this issue Apr 20, 2020 · 4 comments · Fixed by #17978
Labels
candidate Candidate to be added to the current iteration enhancement good first issue Indicates a good issue for first-time contributors Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@sejbot
Copy link

sejbot commented Apr 20, 2020

Describe the enhancement:

With PR #16197 filebeat now supports ingress controller logs which is great.

I would like to change the mapping of the text fields to keyword instead. These three fields would be affected:

  • nginx.ingress_controller.http.request.id
  • nginx.ingress_controller.upstream.alternative_name
  • nginx.ingress_controller.upstream.name

Describe a specific use case for the enhancement or feature:
We have started to use the pipeline and mapping in our elasticsearch environment and would like to visualize metrics split by nginx.ingress_controller.upstream.name, which is not possible when it is a text field.

Changing mapping to keyword would solve this. And I think that the use case of visualizing the nginx.ingress_controller.upstream.name would be more common than free-text searching on the field.

@ycombinator ycombinator added enhancement Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@sejbot sejbot changed the title Change mapping ingress_controller fields mapping from text to keyword Change ingress_controller fields mapping from text to keyword Apr 21, 2020
@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team labels Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@andresrc andresrc assigned ChrsMark and unassigned ChrsMark Apr 21, 2020
@andresrc andresrc added good first issue Indicates a good issue for first-time contributors candidate Candidate to be added to the current iteration labels Apr 21, 2020
@SHolzhauer
Copy link
Contributor

Willing to pick this up, to complete this issue the type defnition in filebeat/module/nginx/* fields.yml needs to be changed right? or is there more to it?

@blakerouse
Copy link
Contributor

@SHolzhauer that it, and run make update in filebeat/ that way all the correct files are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate Candidate to be added to the current iteration enhancement good first issue Indicates a good issue for first-time contributors Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants