Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] When GRPC connected and Stop occurs, a disconnect should be considered stopped #20117

Closed
blakerouse opened this issue Jul 21, 2020 · 0 comments · Fixed by #20118
Assignees

Comments

@blakerouse
Copy link
Contributor

Version: Elastic Agent 7.9 BC2

Currently Elastic Agent has a strict contract for GRPC stopping action. The flow must follow exactly this:

  1. Send stopping to client
  2. Receive stopping from client
  3. Client disconnects

In some cases if the client is quick to send stopping and disconnect, the socket will not flush and the server will not get the stopping message. To help with this, Elastic Agent should be more relaxed. It should also check if the client is currently connected and Stop is performed and the client just disconnects consider that a valid completed stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant