Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple filesets using hints autodiscovery #30132

Closed
tetianakravchenko opened this issue Feb 1, 2022 · 2 comments
Closed

Multiple filesets using hints autodiscovery #30132

tetianakravchenko opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Comments

@tetianakravchenko
Copy link
Contributor

tetianakravchenko commented Feb 1, 2022

In this PR was changed the default behavior and now all filesets will be disabled unless explicitly configured.

Cuurrent state:
From documentation it seems that it is possible to set only 1 fileset
https://www.elastic.co/guide/en/beats/filebeat/current/configuration-autodiscover-hints.html#_co_elastic_logsfileset:

You can either configure a single fileset like this:

co.elastic.logs/fileset: access

Desired state:
be able to provide multiple values of fileset configuration, example:

annotations:
        co.elastic.logs/enabled: "true"
        co.elastic.logs/module: elasticsearch
        co.elastic.logs/fileset: server,slowlog,audit
@tetianakravchenko tetianakravchenko added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Feb 1, 2022
@tetianakravchenko
Copy link
Contributor Author

Outcome of the discussion:

  1. Other option for this issue:
    change default behavior in case of using hints-based auto discovery and enable all filesets of the module

  2. Try workaround and set multiple modules
    https://www.elastic.co/guide/en/beats/filebeat/current/configuration-autodiscover-hints.html#_multiple_sets_of_hints
    smth like: (not tested!)

annotations:
  co.elastic.logs/1.module: elasticsearch
  co.elastic.logs/1.fileset: server
  co.elastic.logs/2.module: elasticsearch
  co.elastic.logs/2.fileset: slowlog
...

@tetianakravchenko tetianakravchenko self-assigned this Mar 20, 2022
@tetianakravchenko
Copy link
Contributor Author

I've checked that on version 8.2.0 all works as expected.
With annotation:

annotations:
        co.elastic.logs/enabled: "true"
        co.elastic.logs/module: elasticsearch

all filesets by the default are available:
in CreateConfig is called getFilesets, that return configuration for module with all available filesets enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

No branches or pull requests

1 participant