Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource metadata in all possible Kubernetes module metricsets #33144

Closed
MichaelKatsoulis opened this issue Sep 21, 2022 · 1 comment
Closed

Add resource metadata in all possible Kubernetes module metricsets #33144

MichaelKatsoulis opened this issue Sep 21, 2022 · 1 comment
Assignees
@tetianakravchenko
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Comments

@MichaelKatsoulis
Copy link
Contributor

As described in #33108 resource metadata such as namespace and node labels/annotations are present only in specific kubernetes metricsets.

In 8.1 release with #29133 , the metricset level enrichers where enhanced to add those metadata. But that was only for pod/container and service.

It makes sense to add those metadata for other namespaced resources such as deployment, replicates, jobs, cronjob, statefulset and daemonset.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2022
@MichaelKatsoulis MichaelKatsoulis added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Sep 21, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2022
@tetianakravchenko tetianakravchenko mentioned this issue Nov 18, 2022
Merged
@tetianakravchenko tetianakravchenko mentioned this issue Dec 22, 2022
Merged
6 tasks
@tetianakravchenko
Copy link
Contributor

PR #33763 was backported to 7.17, 8.5 and 8.6 versions

@tetianakravchenko tetianakravchenko mentioned this issue Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetianakravchenko tetianakravchenko

Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKatsoulis @tetianakravchenko