[MetricBeat] It is not necessary to list all metrics in a AWS region

[kwinstonix]

I have noticed the change

Changed module to call ListMetrics API only once per region #34055

beats/x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go

Lines 184 to 199 in 3017189

	// retrieve all the details for all the metrics available in the current region
	listMetricsOutput, err := aws.GetListMetricsOutput("*", regionName, m.Period, svcCloudwatch)
	if err != nil {
	m.Logger().Errorf("Error while retrieving the list of metrics for region %s: %w", regionName, err)
	}
	if len(listMetricsOutput) == 0 {
	continue
	}
	for namespace, namespaceDetails := range namespaceDetailTotal {
	m.logger.Debugf("Collected metrics from namespace %s", namespace)
	// filter listMetricsOutput by detailed configuration per each namespace
	filteredMetricWithStatsTotal := filterListMetricsOutput(listMetricsOutput, namespace, namespaceDetails)

AWS has so many metrics namespaces and metrics, listing all metrics in one region can lead to more API calls and higher costs. If metric config only contains few namespace and metrics, that problem will be more obvious. I think it is better to list metrics by namespace that is defined in config files.

[botelastic]

This issue doesn't have a Team:<team> label.

[botelastic]

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!