Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP labels are being omitted #40033

Closed
gpop63 opened this issue Jun 26, 2024 · 0 comments · Fixed by #40062
Closed

GCP labels are being omitted #40033

gpop63 opened this issue Jun 26, 2024 · 0 comments · Fixed by #40062
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Comments

@gpop63
Copy link
Contributor

gpop63 commented Jun 26, 2024

When parsing time series objects, we're omitting key labels like instance_id, zone, and project_id.

if k == TimeSeriesResponsePathForECSAvailabilityZone || k == TimeSeriesResponsePathForECSInstanceID || k == TimeSeriesResponsePathForECSAccountID {

This omission seems to be because these are ECS fields. While this is acceptable if the service has metadata, such as compute, it results in missing crucial labels for services without additional metadata logic.

For instance, when fetching the instance/leader_percentage_by_region metric for the spanner service, the instance_id label is missing. This leads to a discrepancy between what we deliver and what users see in the GCP Metrics Explorer.

We need to ensure these ECS fields are included even if the service lacks metadata.

cc: @ishleenk17

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
@gpop63 gpop63 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Jun 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant