Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vagrantfile updates #13065

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Vagrantfile updates #13065

merged 1 commit into from
Jul 25, 2019

Conversation

andrewkroh
Copy link
Member

  • Make Powershell script mostly idempotent.
  • Add win2016 and win2019 boxes.
  • Update to centos-6.10 and fedora29.
  • Make changes for consistency (variable names, spacing).
  • Remove defaults that were specified for syned_folder.

@andrewkroh
Vagrantfile updates
65efb80 
- Make Powershell script mostly idempotent.
- Add win2016 and win2019 boxes.
- Update to centos-6.10 and fedora29.
- Make changes for consistency (variable names, spacing).
- Remove defaults that were specified for syned_folder.
ph
ph approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested win2019 and fedora29 locally and everything look fines on my end, thank you for reformating and renaming the variables in the ruby blocks

@andrewkroh
Copy link
Member Author

Thanks for testing @ph.

@andrewkroh andrewkroh merged commit b74e19c into elastic:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkroh @ph