-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'python3 -m venv' instead of virtualenv #15754
Use 'python3 -m venv' instead of virtualenv #15754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also replace the virtualenv
calls in the Makefile
in the root directory and the one in generator/common/Makefile
.
I'll check that out. I found a few more direct calls to |
Switch over to `python3 -m venv` instead of `virtualenv`. It's the recommended way to create virtual Python environments in 3.4 and above. https://docs.python.org/3/library/venv.html
Remove any direct references to python to always allow a specific python binary or version to be used.
2d113a1
to
06153c3
Compare
It seems that we need to install |
Oh yeah..., Debian has split up the python distribution so you need that package to get the venv module. Will add that. |
Merging this, thanks! |
Switch over to `python3 -m venv` instead of `virtualenv`. It's the recommended way to create virtual Python environments in 3.4 and above. https://docs.python.org/3/library/venv.html Remove any direct references to python to always allow a specific python binary or version to be used.
Switch over to
python3 -m venv
instead ofvirtualenv
. It's the recommended way to create virtual Python environments in 3.4 and above.https://docs.python.org/3/library/venv.html