Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15680 to 7.x: Add keep-backport-label in cherry_pick script #15769

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

ChrsMark
Copy link
Member

Cherry-pick of PR #15680 to 7.x branch. Original message:

What does this PR do?

This PR adds a keep-backport-label in cherry_pick script. If this flag is set then the label needs_backport of the original PR will be preserved.

Why is it important?

In many cases we want to backport to more than one branches so removing the label by default for any backporting action may remove label even if the backports are not completed yet.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

I tested this manually with #15535 and it works.

@jsoriano @kvch what do you think about this?

@ChrsMark ChrsMark merged commit ed232fe into elastic:7.x Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants