Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix null string with contains #20182

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 23, 2020

What

Fixes an issue with a null string

Why is it important?

Otherwise some builds will fail if they need to evaluate all the conditions

Tests

image

@v1v v1v self-assigned this Jul 23, 2020
@v1v v1v added the automation label Jul 23, 2020
@v1v v1v requested a review from a team July 23, 2020 07:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@v1v v1v added the Team:Automation Label for the Observability productivity team label Jul 23, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@v1v v1v marked this pull request as ready for review July 23, 2020 07:30
@v1v v1v merged commit 7579d51 into elastic:master Jul 23, 2020
@v1v v1v deleted the fix/null-env-variable branch July 23, 2020 07:42
@elasticmachine
Copy link
Collaborator

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20182 opened]

  • Start Time: 2020-07-23T07:30:00.487+0000

  • Duration: 122 min 19 sec

Test stats 🧪

Test Results
Failed 13
Passed 11674
Skipped 1682
Total 13369

Test errors

Expand to view the tests failures

  • Name: Build and Test / Auditbeat x-pack / test_connected_udp_ipv4 – test_system_socket.Test

    • Age: 1
    • Duration: 60.116
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_connected_udp_ipv6 – test_system_socket.Test

    • Age: 1
    • Duration: 60.117
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_dns_enrichment – test_system_socket.Test

    • Age: 1
    • Duration: 60.121
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_dns_long_request – test_system_socket.Test

    • Age: 1
    • Duration: 60.115
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_dns_udp_ipv6 – test_system_socket.Test

    • Age: 1
    • Duration: 60.117
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_dns_unidirectional_udp – test_system_socket.Test

    • Age: 1
    • Duration: 60.108
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_multi_udp_upv4 – test_system_socket.Test

    • Age: 1
    • Duration: 60.107
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_no_dns_enrichment – test_system_socket.Test

    • Age: 1
    • Duration: 60.11
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_tcp_ipv4 – test_system_socket.Test

    • Age: 1
    • Duration: 60.107
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_tcp_ipv6_disabled – test_system_socket.Test

    • Age: 1
    • Duration: 60.117
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_udp_ipv4 – test_system_socket.Test

    • Age: 1
    • Duration: 60.116
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_udp_ipv6 – test_system_socket.Test

    • Age: 1
    • Duration: 60.108
    • Error Details: Expected exit code to be 0, but it was 1
  • Name: Build and Test / Auditbeat x-pack / test_udp_ipv6_disabled – test_system_socket.Test

    • Age: 1
    • Duration: 60.119
    • Error Details: Expected exit code to be 0, but it was 1

Steps errors

Expand to view the steps failures

  • Name: General Build Step

    • Description: [2020-07-23T07:53:07.752Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:

    • Duration: 3 min 0 sec

    • Start Time: 2020-07-23T07:53:07.669+0000

    • log

  • Name: Mage build test

    • Description: mage build test

    • Duration: 9 min 40 sec

    • Start Time: 2020-07-23T07:53:52.717+0000

    • log

  • Name: Report to Codecov

    • Description: .ci/scripts/report-codecov.sh auditbeat filebeat heartbeat journalbeat libbeat metricbeat packetbeat winlogbeat

    • Duration: 1 min 27 sec

    • Start Time: 2020-07-23T08:02:45.750+0000

    • log

  • Name: General Build Step

    • Description: [2020-07-23T07:54:48.874Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:

    • Duration: 3 min 59 sec

    • Start Time: 2020-07-23T07:54:48.780+0000

    • log

  • Name: Mage update build test

    • Description: mage update build test

    • Duration: 20 min 31 sec

    • Start Time: 2020-07-23T07:54:19.493+0000

    • log

  • Name: General Build Step

    • Description: [2020-07-23T07:53:15.715Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:

    • Duration: 3 min 58 sec

    • Start Time: 2020-07-23T07:53:15.619+0000

    • log

  • Name: General Build Step

    • Description: [2020-07-23T07:53:50.911Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:

    • Duration: 3 min 59 sec

    • Start Time: 2020-07-23T07:53:50.835+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-23T09:28:32.100Z]  API version:       1.40
[2020-07-23T09:28:32.100Z]  Go version:        go1.12.5
[2020-07-23T09:28:32.100Z]  Git commit:        74b1e89
[2020-07-23T09:28:32.100Z]  Built:             Thu Jul 25 21:18:17 2019
[2020-07-23T09:28:32.100Z]  OS/Arch:           darwin/amd64
[2020-07-23T09:28:32.100Z]  Experimental:      false
[2020-07-23T09:28:32.100Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-07-23T09:28:32.100Z] It requires Docker daemon to be installed and running
[2020-07-23T09:29:05.416Z] Still waiting to schedule task
[2020-07-23T09:29:05.416Z] Waiting for next available executor on ‘macosx’
[2020-07-23T09:31:45.042Z] Cancelling nested steps due to timeout
[2020-07-23T09:31:45.340Z] Failed in branch Generators
[2020-07-23T09:31:47.125Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats
[2020-07-23T09:31:47.470Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-23T09:31:47.497Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Lint
[2020-07-23T09:31:47.658Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-23T09:31:47.815Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-23T09:31:47.975Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-23T09:31:48.136Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-23T09:31:48.287Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-23T09:31:48.452Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Packetbeat-Linux
[2020-07-23T09:31:48.611Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-23T09:31:48.769Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-23T09:31:48.922Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-23T09:31:49.081Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-23T09:31:49.243Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-23T09:31:49.399Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-23T09:31:49.555Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Filebeat-oss
[2020-07-23T09:31:49.710Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-23T09:31:49.864Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-23T09:31:50.019Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-23T09:31:50.172Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-23T09:31:50.328Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-23T09:31:50.482Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-23T09:31:50.667Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-23T09:31:50.824Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-23T09:31:50.979Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-23T09:31:51.137Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-23T09:31:51.298Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-23T09:31:51.505Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-23T09:31:51.667Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-23T09:31:51.825Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-23T09:31:52.004Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-23T09:31:52.180Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-23T09:31:52.347Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-23T09:31:52.517Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Packetbeat-Mac-OS-X
[2020-07-23T09:31:52.701Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-07-23T09:31:52.872Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-23T09:31:53.046Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests
[2020-07-23T09:31:53.226Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-OSS-Python-Integration-tests
[2020-07-23T09:31:53.412Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Heartbeat-Windows
[2020-07-23T09:31:53.591Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Packetbeat-Windows
[2020-07-23T09:31:53.764Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-23T09:31:54.229Z] + cat
[2020-07-23T09:31:54.229Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-23T09:31:54.229Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-23T09:32:00.836Z] runbld>>> runbld started
[2020-07-23T09:32:00.836Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-23T09:32:02.751Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20182' in order of occurrence in the config (last value wins).
[2020-07-23T09:32:04.137Z] runbld>>> Debug logging enabled.
[2020-07-23T09:32:04.137Z] runbld>>> Storing result
[2020-07-23T09:32:04.398Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-23T09:32:04.398Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723093204-C545AF2D
[2020-07-23T09:32:04.398Z] runbld>>> Adding system facts.
[2020-07-23T09:32:05.343Z] runbld>>> Adding vcs info for the latest commit:  7d8974fc65a17879880a9d77c7aaf4586537e0b8
[2020-07-23T09:32:05.343Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-23T09:32:05.343Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-23T09:32:05.604Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-23T09:32:05.604Z] Processing JUnit reports with runbld...
[2020-07-23T09:32:05.870Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-23T09:32:05.870Z] runbld>>> DURATION: 29ms
[2020-07-23T09:32:05.870Z] runbld>>> STDOUT: 40 bytes
[2020-07-23T09:32:05.870Z] runbld>>> STDERR: 49 bytes
[2020-07-23T09:32:05.870Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-23T09:32:05.870Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats
[2020-07-23T09:32:07.254Z] runbld>>> Storing build metadata: 
[2020-07-23T09:32:07.254Z] runbld>>> Adding test report.
[2020-07-23T09:32:07.254Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats
[2020-07-23T09:32:07.824Z] runbld>>> Found 125 test output files
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-23T09:32:09.220Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20182/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-23T09:32:10.168Z] runbld>>> Test output logs contained: Errors: 0 Failures: 13 Tests: 13369 Skipped: 1441
[2020-07-23T09:32:10.430Z] runbld>>> Storing result
[2020-07-23T09:32:10.430Z] runbld>>> FAILURES: 13
[2020-07-23T09:32:12.980Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-23T09:32:12.980Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723093204-C545AF2D
[2020-07-23T09:32:12.980Z] runbld>>> Email notification disabled by environment variable.
[2020-07-23T09:32:12.980Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-23T09:32:18.647Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20182
[2020-07-23T09:32:18.853Z] [INFO] getVaultSecret: Getting secrets
[2020-07-23T09:32:18.959Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-23T09:32:20.228Z] + chmod 755 generate-build-data.sh
[2020-07-23T09:32:20.228Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20182/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20182/runs/1 FAILURE 7339469
[2020-07-23T09:32:20.228Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20182/runs/1/steps/?limit=10000 -o steps-info.json
[2020-07-23T09:32:25.423Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20182/runs/1/tests/?status=FAILED -o tests-errors.json

v1v added a commit to v1v/beats that referenced this pull request Jul 27, 2020
…ne-2.0

* upstream/master: (41 commits)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232)
  fix: use a fixed worker type for tests (elastic#20130)
  [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186)
  [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218)
  [Ingest Manager] Prevent closing closed reader (elastic#20214)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191)
  Testing: Ignore timestamp from cylance/protect dataset (elastic#20211)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207)
  [CI] remove codecov step (elastic#20102)
  [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172)
  Remove f5/firepass rsa2elk fileset (elastic#20160)
  [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118)
  Fix fileset field prefixing (elastic#20170)
  Fix terminating pod autodiscover issue (elastic#20084)
  Call host parser only once when building light metricsets (elastic#20149)
  [CI] fix null string with contains (elastic#20182)
  [Ingest Manager] Fix failing unit tests on windows (elastic#20127)
  [Filebeat] Update crowdstrike module (elastic#20138)
  [docs] Add x-pack role to relevant metricsets (elastic#20167)
  ...
v1v added a commit to v1v/beats that referenced this pull request Jul 30, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 30, 2020
v1v added a commit that referenced this pull request Jul 31, 2020
…certain conditions (#20069) (#20333)

* [CI] MacOS stages for branches/tags and PRs when certain conditions (#20069)
* [CI] fix null string with contains (#20182)
v1v added a commit that referenced this pull request Jul 31, 2020
…certain conditions (#20069) (#20334)

* [CI] MacOS stages for branches/tags and PRs when certain conditions (#20069)
* [CI] fix null string with contains (#20182)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…certain conditions (elastic#20069) (elastic#20333)

* [CI] MacOS stages for branches/tags and PRs when certain conditions (elastic#20069)
* [CI] fix null string with contains (elastic#20182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants