Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster filter on Kubernetes Overview ECS dashboard #26919

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

akshay-saraswat
Copy link
Contributor

@akshay-saraswat akshay-saraswat commented Jul 15, 2021

What does this PR do?

Added a Cluster name selector on the [Metricbeat Kubernetes] Overview ECS dashboard. This selector will be used as a filter for the dashboard. Also, added a blur for this selector on the Kubernetes module documentation page to explain how this selector works and where it sources the data from. Added a screenshot of the [Metricbeat Kubernetes] Overview ECS dashboard on the Kubernetes module documentation page because we need a visual to explain the Cluster filter.

Why is it important?

We have added a new Cluster name field in metricbeat. this field will not be useful unless users could discover it in some form
in UI.

Checklist

  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

Screen Shot Kubernetes Dashboard

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 15, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Jul 15, 2021

💚 CLA has been signed

@akshay-saraswat akshay-saraswat force-pushed the Kubernetes-overview-dashboard-cluster-filter branch from d4bc469 to d4deed4 Compare July 15, 2021 16:13
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-16T19:43:02.835+0000

  • Duration: 75 min 4 sec

  • Commit: a1540a2

Test stats 🧪

Test Results
Failed 0
Passed 8935
Skipped 2466
Total 11401

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8935
Skipped 2466
Total 11401

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, thanks for working on this @akshay-saraswat but I think the Dashboard screenshot needs to be replaced with a more representative one displaying nodes, deployments, etc as well as the usage of the cluster filter.

@akshay-saraswat akshay-saraswat force-pushed the Kubernetes-overview-dashboard-cluster-filter branch 2 times, most recently from 99082eb to 7df424b Compare July 16, 2021 15:43
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Feel free to merge it once CI is green (I think you need to sign the CLA).

@akshay-saraswat akshay-saraswat added the Team:Integrations Label for the Integrations team label Jul 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2021
@akshay-saraswat akshay-saraswat force-pushed the Kubernetes-overview-dashboard-cluster-filter branch from 7df424b to a1540a2 Compare July 16, 2021 19:42
@kaiyan-sheng kaiyan-sheng added the needs_backport PR is waiting to be backported to other branches. label Jul 16, 2021
@ChrsMark ChrsMark added backport-v7.15.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Jul 19, 2021
@ChrsMark ChrsMark merged commit 25f4091 into master Jul 19, 2021
mergify bot pushed a commit that referenced this pull request Jul 19, 2021
mergify bot pushed a commit that referenced this pull request Jul 19, 2021
ChrsMark added a commit that referenced this pull request Jul 19, 2021
… dashboard (#26946)

* Add Cluster filter on Kubernetes Overview ECS dashboard (#26919)

(cherry picked from commit 25f4091)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Akshay Saraswat <[email protected]>
Co-authored-by: Chris Mark <[email protected]>
ChrsMark pushed a commit that referenced this pull request Jul 19, 2021
)

(cherry picked from commit 25f4091)

Co-authored-by: Akshay Saraswat <[email protected]>
@jsoriano
Copy link
Member

Dashboard added here has some kind of issue, test_dashboards fails with:

E         Exiting: Failed to import dashboard: Failed to load directory /go/src/github.com/elastic/beats/metricbeat/build/system-tests/run/test_base.Test.test_dashboards/kibana/7/dashboard:
E           error loading /go/src/github.com/elastic/beats/metricbeat/build/system-tests/run/test_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-kubernetes-overview.json: returned 500 to import file: <nil>. Response: {"statusCode":500,"error":"Internal Server Error","message":"An internal server error occurred."}
E         
E       assert 1 == 0

test_dashboards can be executed with PYTEST_ADDOPTS="-k test_dashboards" mage pythonIntegTest from the metricbeat directory.

It may be because it uses version 7.14.0 that hasn't been released yet, but not sure.

Why wasn't this detected by CI? These were the logs there:

[2021-07-16T20:05:02.815Z] >> python test: Integration-kubernetes Testing
[2021-07-16T20:05:02.815Z] Cache entry deserialization failed, entry ignored
[2021-07-16T20:05:20.912Z] >> python test: Integration-kubernetes Testing - No tests found.

It seems that selective testing was triggered as only one module was modified, and no test was executed in this case. test_dashboards should have been run to detect this issue.

@ChrsMark @akshay-saraswat could you please review this dashboard?

cc @sayden @kvch

@ChrsMark
Copy link
Member

@jsoriano I think that Dashboard is ok. The backports to 7.x and 7.14 should work with 7.14 compatible Dasboards. I think that we miss the update of the testing stack, sth like #24957.

@jsoriano
Copy link
Member

@jsoriano I think that Dashboard is ok. The backports to 7.x and 7.14 should work with 7.14 compatible Dasboards. I think that we miss the update of the testing stack, sth like #24957.

But test_dashboards is broken in the meantime in master and 7.x, see #26959 for example.

@ChrsMark
Copy link
Member

I think that master, 7.x and 7.14 should be compatible with 7.14 dashboards and we can fix it with a change like #24957.

The weird thing is that this PR was green at https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-26919/5/pipeline, 🤔 .

In any case we need to update

image: docker.elastic.co/integrations-ci/beats-kibana:${KIBANA_VERSION:-7.12.0}-1
, no? I can prepare a PR for this if we agree.

@jsoriano
Copy link
Member

The weird thing is that this PR was green at https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-26919/5/pipeline, thinking .

Yes, this is what I mention in #26919 (comment), it seems it was not detected in CI because only the python tests for kubernetes were executed, what doesn't include test_dashboards.

Why wasn't this detected by CI? These were the logs there:

[2021-07-16T20:05:02.815Z] >> python test: Integration-kubernetes Testing
[2021-07-16T20:05:02.815Z] Cache entry deserialization failed, entry ignored
[2021-07-16T20:05:20.912Z] >> python test: Integration-kubernetes Testing - No tests found.

I am looking now at how we can make dashboards tests to be executed for modules too.

In any case we need to update

image: docker.elastic.co/integrations-ci/beats-kibana:${KIBANA_VERSION:-7.12.0}-1

We cannot do this change till 7.14 is released. I think we need to revert the change on this dashboard, or make it work with the current tested versions. If not we are going to have broken builds till the release of 7.14.

mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jul 20, 2021
* master:
  Forward port 7.13.4 to master (elastic#26971)
  Use MustAddMetricSet in all metricsets (elastic#26907)
  add_process_metadata: enrich process info with process owner (elastic#21068) (elastic#21111)
  Use aws sdk paginator for FilterLogEvents and GetMetricData (elastic#26852)
  [Filebeat] Allow - for source IP for AWS S3 Access pipeline (elastic#26940)
  Increase timeout to 30secs (elastic#26841)
  Add Cluster filter on Kubernetes Overview ECS dashboard (elastic#26919)
@kaiyan-sheng kaiyan-sheng deleted the Kubernetes-overview-dashboard-cluster-filter branch July 20, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug docs needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants