Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #28080

Merged
merged 8 commits into from
Nov 4, 2021
Merged

Spelling #28080

merged 8 commits into from
Nov 4, 2021

Conversation

austinsonger
Copy link
Contributor

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 23, 2021
@austinsonger austinsonger marked this pull request as ready for review September 23, 2021 02:57
@austinsonger austinsonger requested a review from a team as a code owner September 23, 2021 02:57
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2021

This pull request does not have a backport label. Could you fix it @austinsonger? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 23, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 23, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-03T09:08:23.519+0000

  • Duration: 147 min 41 sec

  • Commit: d532a76

Test stats 🧪

Test Results
Failed 0
Passed 54119
Skipped 5355
Total 59474

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@botelastic
Copy link

botelastic bot commented Oct 23, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 23, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the Stalled label Oct 25, 2021
@jsoriano
Copy link
Member

/test

jsoriano
jsoriano reviewed Oct 25, 2021
View reviewed changes
dev-tools/ecs-migration.yml Outdated
to: process.thread.id
alias: true
beat: filebeat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, I wonder where these new fields come from 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. What is the origin of this?

If everything up from here in this file were reverted I think this would be good to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems that these aliases were removed in #27919, so perhaps this comes from the resolution of a merge conflict?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed them, let's see if build goes green and ready to go.

@jsoriano jsoriano requested a review from a team as a code owner November 3, 2021 09:08
@jsoriano jsoriano added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 3, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 3, 2021
@jsoriano jsoriano merged commit 2d173ea into elastic:master Nov 4, 2021
mergify bot pushed a commit that referenced this pull request Nov 4, 2021
@austinsonger
Fix some spelling mistakes (#28080)
25085b6 
(cherry picked from commit 2d173ea)
@mergify mergify bot mentioned this pull request Nov 4, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 4, 2021
@austinsonger
Fix some spelling mistakes (#28080)
7771c7b 
(cherry picked from commit 2d173ea)
@mergify mergify bot mentioned this pull request Nov 4, 2021
Merged
mtojek pushed a commit that referenced this pull request Nov 8, 2021
@mergify @austinsonger
Fix some spelling mistakes (#28080) (#28819)
24bd871 
(cherry picked from commit 2d173ea)

Co-authored-by: Austin Songer <[email protected]>
mtojek pushed a commit that referenced this pull request Nov 8, 2021
@mergify @austinsonger
Fix some spelling mistakes (#28080) (#28820)
ae80fe8 
(cherry picked from commit 2d173ea)

Co-authored-by: Austin Songer <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Nov 8, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
3afea6c 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-arch-…
061692b 
…in-the-package-binareis

* upstream/master:
  allows disable pod events enrichment with deployment name (elastic#28521)
  Remove Docker input from Filebeat (elastic#28817)
  [breaking] Make default_field: false the default for all fields (elastic#28596)
  Osquerybeat: Improve osquery client connect code (elastic#28848)
  Add crawler  metrics into the stats metricset for Enterprise Search (elastic#28790)
  Remove the now deprecated appsearch module from metricbeat (elastic#28850)
  Remove Beat generators (elastic#28816)
  chore: upload files to Google Storage when they exist (elastic#28836)
  Revert "chore(ci): disable E2E tests in Beats (elastic#28715)" (elastic#28812)
  Deprecate generating custom Beats (elastic#28814)
  [Metricbeat] upgrade flatbuffers to 1.12.1 (elastic#28094)
  Osquerybeat: Fix restart flags after previously bad config (elastic#28827)
  Force ECS and JSON logging for libbeat/logp (elastic#28573)
  Filebeat: Error on startup for unconfigured module (elastic#28818)
  Deprecate log input in favour of filestream (elastic#28623)
  Fix some spelling mistakes (elastic#28080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinsonger @elasticmachine @jsoriano @andrewkroh