Pass context with timeout to FQDN lookup #37756

ycombinator · 2024-01-25T19:52:32Z

Proposed commit message

This PR improves the FQDN lookup function calls by passing a context with a 1 minute timeout, thus preventing the calls from blocking indefinitely due to DNS issues and such.

Depends on: elastic/go-sysinfo#199 and a new release of that library.

mergify · 2024-01-25T19:53:07Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2024-01-25T20:38:18Z

❕ Build Aborted

Expand to view the summary

Build stats

Duration: 45 min 16 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2024-01-25T22:12:56Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fqdn-ctx upstream/fqdn-ctx
git merge upstream/main
git push upstream fqdn-ctx

elasticmachine · 2024-01-25T22:15:59Z

❕ Build Aborted

Expand to view the summary

Build stats

Duration: 132 min 33 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-01-25T22:21:08Z

💔 Build Failed

Expand to view the summary

Build stats

Duration: 133 min 38 sec

Pipeline error

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-02-01T02:12:30Z

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

libbeat/processors/add_host_metadata/add_host_metadata.go

CHANGELOG.next.asciidoc

elasticmachine · 2024-02-01T02:44:02Z

❕ Build Aborted

Expand to view the summary

Build stats

Duration: 12 min 33 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-02-01T02:45:14Z

❕ Build Aborted

Expand to view the summary

Build stats

Duration: 32 min 26 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz · 2024-02-01T21:54:37Z

libbeat/cmd/instance/beat.go

+	fqdnLookupCtx, cancel := context.WithTimeout(context.Background(), 1*time.Minute)
+	defer cancel()
+
+	fqdn, err := h.FQDNWithContext(fqdnLookupCtx)


If this times out it falls back to the non-FQDN, does that ever get updated? Or is the Beat stuck with the non-FQDN.

If the first rule of network communication is "never make a request without a timeout", the second one is "never rely on a single network request to succeed".

No, it doesn't get updated. I agree that it would be nice to keep retrying but I also think that's out of scope for this PR here; this one is just about implementing the first rule. I'll file a separate issue to implement the second one.

elasticmachine · 2024-02-02T01:25:29Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 163 min 26 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ycombinator · 2024-02-02T13:21:25Z

libbeat/processors/add_host_metadata/add_host_metadata.go

@@ -96,7 +97,7 @@ func New(cfg *config.C) (beat.Processor, error) {
 	}

 	// create a unique ID for this instance of the processor
-	cbIDStr := ""
+	var cbIDStr string


This change is unrelated to this PR; it is included in this PR to make the linter happy. Without it, the linter was failing with this error:

assigned to cbIDStr, but reassigned without using the value (wastedassign)

elasticmachine · 2024-02-02T15:13:50Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2024-02-02T13:06:35.282+0000
Duration: 127 min 59 sec

Test stats 🧪

Test	Results
Failed	0
Passed	23348
Skipped	1554
Total	24902

Steps errors

Expand to view the steps failures

`Google Storage Download`

Took 0 min 5 sec . View more details here
Description: [2024-02-02T13:27:29.142Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:

`Checks if running on a Unix-like node`

Took 0 min 0 sec . View more details here

`Error signal`

Took 0 min 0 sec . View more details here
Description: untar: step failed with error null

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-02-02T16:07:19Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 166 min 48 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-02-02T18:26:07Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2024-02-02T16:53:46.619+0000
Duration: 92 min 6 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28346
Skipped	2014
Total	30360

Steps errors

Expand to view the steps failures

`metricbeat-goIntegTest - mage goIntegTest`

Took 34 min 2 sec . View more details here
Description: mage goIntegTest

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-02-02T19:01:33Z

💔 Build Failed

Buildkite Build
Commit: 9f3b2ee

Failed CI Steps

Package pipeline

History

💔 Build #2396 failed 6fbce21
💚 Build #2373 succeeded f8245b1
💚 Build #2370 succeeded 25263f7

cc @ycombinator

elasticmachine · 2024-02-02T21:04:34Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 165 min 45 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

* Pass context with timeout to FQDN lookup * Add temporary gomod replace * Add CHANGELOG entry * Update dependency * Update method calls * Add nolint for rand deprecation warning * Make linter happy (cherry picked from commit e4b448f) # Conflicts: # NOTICE.txt # go.mod # go.sum

) * Pass context with timeout to FQDN lookup (#37756) * Pass context with timeout to FQDN lookup * Add temporary gomod replace * Add CHANGELOG entry * Update dependency * Update method calls * Add nolint for rand deprecation warning * Make linter happy (cherry picked from commit e4b448f) # Conflicts: # NOTICE.txt # go.mod # go.sum * Fix conflicts --------- Co-authored-by: Shaunak Kashyap <[email protected]>

* Pass context with timeout to FQDN lookup * Add temporary gomod replace * Add CHANGELOG entry * Update dependency * Update method calls * Add nolint for rand deprecation warning * Make linter happy

ycombinator requested a review from a team as a code owner January 25, 2024 19:52

ycombinator requested review from belimawr and rdner January 25, 2024 19:52

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2024

mergify bot assigned ycombinator Jan 25, 2024

ycombinator marked this pull request as draft January 25, 2024 19:56

ycombinator removed request for belimawr and rdner January 25, 2024 19:56

ycombinator added bug Team:Elastic-Agent Label for the Agent team backport-v8.12.0 Automated backport with mergify labels Jan 25, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2024

ycombinator removed the Team:Elastic-Agent Label for the Agent team label Feb 1, 2024

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2024

ycombinator force-pushed the fqdn-ctx branch from 812099e to 376c784 Compare February 1, 2024 02:12

ycombinator marked this pull request as ready for review February 1, 2024 02:12

ycombinator requested a review from a team as a code owner February 1, 2024 02:12

ycombinator added the Team:Elastic-Agent Label for the Agent team label Feb 1, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2024

andrewkroh reviewed Feb 1, 2024

View reviewed changes

libbeat/processors/add_host_metadata/add_host_metadata.go Outdated Show resolved Hide resolved

CHANGELOG.next.asciidoc Show resolved Hide resolved

ycombinator force-pushed the fqdn-ctx branch from 0ae89a3 to febb133 Compare February 1, 2024 02:38

ycombinator requested a review from andrewkroh February 1, 2024 02:39

andrewkroh mentioned this pull request Feb 1, 2024

build(deps): bump github.com/elastic/go-sysinfo from 1.11.2 to 1.12.0 #37817

Closed

cmacknz reviewed Feb 1, 2024

View reviewed changes

cmacknz mentioned this pull request Feb 1, 2024

Pass context with timeout to FQDN lookup elastic/elastic-agent#4147

Merged

ycombinator mentioned this pull request Feb 1, 2024

Retry FQDN lookup until it succeeds #37835

Open

ycombinator requested a review from cmacknz February 1, 2024 22:41

ycombinator force-pushed the fqdn-ctx branch from febb133 to 9f737ec Compare February 1, 2024 22:41

ycombinator commented Feb 2, 2024

View reviewed changes

ycombinator force-pushed the fqdn-ctx branch from f8245b1 to 6fbce21 Compare February 2, 2024 16:53

ycombinator added 7 commits February 2, 2024 10:19

Pass context with timeout to FQDN lookup

cfc1e81

Add temporary gomod replace

209f013

Add CHANGELOG entry

b145464

Update dependency

decda55

Update method calls

e5d69f2

Add nolint for rand deprecation warning

8855ce8

Make linter happy

9f3b2ee

ycombinator force-pushed the fqdn-ctx branch from 6fbce21 to 9f3b2ee Compare February 2, 2024 18:19

ycombinator enabled auto-merge (squash) February 2, 2024 19:19

cmacknz approved these changes Feb 2, 2024

View reviewed changes

ycombinator merged commit e4b448f into elastic:main Feb 2, 2024
127 of 128 checks passed

mergify bot mentioned this pull request Feb 2, 2024

[8.12](backport #37756) Pass context with timeout to FQDN lookup #37849

Merged

ycombinator deleted the fqdn-ctx branch February 2, 2024 21:06

Pass context with timeout to FQDN lookup #37756

Pass context with timeout to FQDN lookup #37756

Conversation

ycombinator commented Jan 25, 2024

Proposed commit message

mergify bot commented Jan 25, 2024

elasticmachine commented Jan 25, 2024

❕ Build Aborted

Build stats

🤖 GitHub comments

mergify bot commented Jan 25, 2024

elasticmachine commented Jan 25, 2024

❕ Build Aborted

Build stats

🤖 GitHub comments

elasticmachine commented Jan 25, 2024

💔 Build Failed

Build stats

Pipeline error

❕ Flaky test report

🤖 GitHub comments

elasticmachine commented Feb 1, 2024

elasticmachine commented Feb 1, 2024

❕ Build Aborted

Build stats

🤖 GitHub comments

elasticmachine commented Feb 1, 2024

❕ Build Aborted

Build stats

🤖 GitHub comments

cmacknz Feb 1, 2024

Choose a reason for hiding this comment

ycombinator Feb 1, 2024

Choose a reason for hiding this comment

ycombinator Feb 1, 2024

Choose a reason for hiding this comment

elasticmachine commented Feb 2, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

ycombinator Feb 2, 2024

Choose a reason for hiding this comment

elasticmachine commented Feb 2, 2024

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

Google Storage Download

Checks if running on a Unix-like node

Error signal

🤖 GitHub comments

elasticmachine commented Feb 2, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

elasticmachine commented Feb 2, 2024

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

metricbeat-goIntegTest - mage goIntegTest

Error signal

🤖 GitHub comments

elasticmachine commented Feb 2, 2024

💔 Build Failed

Failed CI Steps

History

elasticmachine commented Feb 2, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

`Google Storage Download`

`Checks if running on a Unix-like node`

`Error signal`

`metricbeat-goIntegTest - mage goIntegTest`

`Error signal`