Fix file handle leak when handling errors in filestream #37973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files were not closed properly in some rare error cases.
rdner
added
bug
Filebeat
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
6 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
belimawr
requested changes
Feb 12, 2024
There was a problem hiding this comment.
There is still a f.Close() left in openFile that could lead to double closing the file in case of an error.
It's here:
beats/filebeat/input/filestream/input.go
Line 285 in eedae74
💚 Build Succeeded
History
cc @rdner |
💚 Build Succeeded
History
cc @rdner |
💚 Build Succeeded
History
cc @rdner |
💚 Build Succeeded
History
cc @rdner |
💚 Build Succeeded
History
cc @rdner |
💔 Build Failed
Failed CI StepsHistory
cc @rdner |
belimawr
approved these changes
Feb 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Files were not closed properly in some rare error cases. (cherry picked from commit f7e5b4c) # Conflicts: # filebeat/input/filestream/input.go
rdner
added a commit
that referenced
this pull request
Feb 13, 2024
…filestream (#37995) * Fix file handle leak when handling errors in filestream (#37973) Files were not closed properly in some rare error cases. (cherry picked from commit f7e5b4c) # Conflicts: # filebeat/input/filestream/input.go --------- Co-authored-by: Denis <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
Files were not closed properly in some rare error cases. (cherry picked from commit f7e5b4c) # Conflicts: # filebeat/input/filestream/input.go
rdner
added a commit
that referenced
this pull request
Feb 14, 2024
…filestream (#38013) * Fix file handle leak when handling errors in filestream (#37973) Files were not closed properly in some rare error cases. (cherry picked from commit f7e5b4c) # Conflicts: # filebeat/input/filestream/input.go --------- Co-authored-by: Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files were not closed properly in some rare error cases.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
The existing tests should make sure that the existing functionality is not broken.
Related issues