Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netflow] Restore netflow input on Windows #39024

Merged

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 17, 2024

Proposed commit message

  • In 8.13, the netflow input was accidentally removed from the list of inputs for Windows. This restores netflow as an input under Windows.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run the netflow input on Windows

Related issues

- In 8.13, the netflow was accidentally removed from the list of inputs
for Windows. This restores netflow as an input under Windows.
@taylor-swanson taylor-swanson added bug Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Apr 17, 2024
@taylor-swanson taylor-swanson self-assigned this Apr 17, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 17, 2024
Copy link
Contributor

mergify bot commented Apr 17, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @taylor-swanson? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@taylor-swanson taylor-swanson added the backport-v8.13.0 Automated backport with mergify label Apr 17, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 17, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 118 min 1 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@taylor-swanson taylor-swanson marked this pull request as ready for review April 17, 2024 20:53
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 17, 2024 20:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

mergify bot commented Apr 18, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bug/restore-windows-netflow upstream/bug/restore-windows-netflow
git merge upstream/main
git push upstream bug/restore-windows-netflow

@taylor-swanson taylor-swanson merged commit 5e16f25 into elastic:main Apr 18, 2024
32 of 34 checks passed
@taylor-swanson taylor-swanson deleted the bug/restore-windows-netflow branch April 18, 2024 16:29
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
- In 8.13, the netflow was accidentally removed from the list of inputs
for Windows. This restores netflow as an input under Windows.

(cherry picked from commit 5e16f25)
@taylor-swanson taylor-swanson added the backport-v8.14.0 Automated backport with mergify label Apr 22, 2024
taylor-swanson added a commit that referenced this pull request Apr 22, 2024
…39059)

* [netflow] Restore netflow input on Windows (#39024)

- In 8.13, the netflow was accidentally removed from the list of inputs
for Windows. This restores netflow as an input under Windows.

(cherry picked from commit 5e16f25)

---------

Co-authored-by: Taylor Swanson <[email protected]>
Co-authored-by: Taylor Swanson <[email protected]>
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
- In 8.13, the netflow was accidentally removed from the list of inputs
for Windows. This restores netflow as an input under Windows.

(cherry picked from commit 5e16f25)
taylor-swanson added a commit that referenced this pull request Apr 22, 2024
…39119)

* [netflow] Restore netflow input on Windows (#39024)

- In 8.13, the netflow was accidentally removed from the list of inputs
for Windows. This restores netflow as an input under Windows.

(cherry picked from commit 5e16f25)

---------

Co-authored-by: Taylor Swanson <[email protected]>
Co-authored-by: Taylor Swanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify bug Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants