Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winlogbeat] Recover from error 87 if found #39781

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 31, 2024

Proposed commit message

Adds ERROR_INVALID_PARAMETER as a recoverable error type.

There have been some reports that under heavy load and when automatic event log backups, a race condition can happen where the handle is reported as invalid when doing the call to EvtNext. This will prevent users from needing to restart winlogbeat when this happens.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2024
Copy link
Contributor

mergify bot commented May 31, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @marc-gr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@marc-gr marc-gr force-pushed the feat/winlogbeat/recover-from-err-87 branch from 727e4f3 to 409abfb Compare May 31, 2024 15:30
@marc-gr marc-gr marked this pull request as ready for review May 31, 2024 15:31
@marc-gr marc-gr requested a review from a team as a code owner May 31, 2024 15:31
@marc-gr marc-gr added backport-skip Skip notification from the automated backport with mergify Team:Security-Windows Platform Windows Platform Team in Security Solution labels May 31, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2024
@marc-gr marc-gr merged commit d535d17 into elastic:main Jun 3, 2024
14 of 16 checks passed
@marc-gr marc-gr deleted the feat/winlogbeat/recover-from-err-87 branch June 3, 2024 07:57
shmsr pushed a commit to shmsr/beats that referenced this pull request Jun 4, 2024
@marc-gr marc-gr added backport-v8.14.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jun 12, 2024
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
marc-gr added a commit that referenced this pull request Jun 12, 2024
…39872)

* Recover from error 87 if found (#39781)

(cherry picked from commit d535d17)

* Update CHANGELOG.next.asciidoc

---------

Co-authored-by: Marc Guasch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify enhancement Team:Security-Windows Platform Windows Platform Team in Security Solution Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants