Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/salesforce: bump github.com/golang-jwt/jwt to v5 #39823

Merged
merged 1 commit into from
Jun 7, 2024
Merged

x-pack/filebeat/input/salesforce: bump github.com/golang-jwt/jwt to v5 #39823

merged 1 commit into from
Jun 7, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 7, 2024

Proposed commit message

This reduces the dep count since all other uses of the package are at v5. The API that is used here does not change.

https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify labels Jun 7, 2024
@efd6 efd6 self-assigned this Jun 7, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 7, 2024
@efd6
x-pack/filebeat/input/salesforce: bump github.com/golang-jwt/jwt to v5
295b995 
This reduces the dep count since all other uses of the package are at
v5. The API that is used here does not change.

https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md
@efd6 efd6 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Jun 7, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 7, 2024
@efd6 efd6 marked this pull request as ready for review June 7, 2024 06:54
@efd6 efd6 requested review from a team as code owners June 7, 2024 06:54
@efd6 efd6 merged commit 132a06b into elastic:main Jun 7, 2024
107 checks passed
@kruskall
Copy link
Member

kruskall commented Jun 8, 2024

There's no need to include the jwt dependency, please see #39804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@shmsr shmsr shmsr approved these changes

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @kruskall @cmacknz @shmsr