Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x-pack/filebeat/netflow] add netflow status reporting under Agent management #40080

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Jul 2, 2024

Proposed commit message

This PR extends netflow input with status reporting capabilities when running under management of elastic-agent. Also, it adds an integration test for netflow

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A

Author's Checklist

N/A

How to test this PR locally

mage goIntegTest

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

@pkoutsovasilis pkoutsovasilis added enhancement Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jul 2, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Jul 2, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 2, 2024
Copy link
Contributor

mergify bot commented Jul 2, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pkoutsovasilis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review July 2, 2024 20:42
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner July 2, 2024 20:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@andrewkroh andrewkroh added the Filebeat Filebeat label Jul 2, 2024
Copy link
Member

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b pkoutsovasilis/netflow_status_report upstream/pkoutsovasilis/netflow_status_report
git merge upstream/main
git push upstream pkoutsovasilis/netflow_status_report

@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner July 4, 2024 17:32
@pkoutsovasilis pkoutsovasilis added the backport-skip Skip notification from the automated backport with mergify label Jul 4, 2024
@pkoutsovasilis pkoutsovasilis enabled auto-merge (squash) July 4, 2024 20:29
@pkoutsovasilis pkoutsovasilis merged commit 8e607a3 into elastic:main Jul 4, 2024
19 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/netflow_status_report branch July 4, 2024 22:25
@pierrehilbert
Copy link
Collaborator

@pkoutsovasilis Don't we want to backport this on the 8.15 branch?

@pkoutsovasilis
Copy link
Contributor Author

@pkoutsovasilis Don't we want to backport this on the 8.15 branch?

that's a good question ty for asking @pierrehilbert 🙂 AFAIK this is an "enhancement" so the policy is no backporting?! but maybe I am wrong!?

@pierrehilbert
Copy link
Collaborator

From what I can see we don't have our first BC for 8.15 so this is probably okay.
I would say it depends how important this is.

@pkoutsovasilis
Copy link
Contributor Author

From what I can see we don't have our first BC for 8.15 so this is probably okay. I would say it depends how important this is.

hmm I see your point! @andrewkroh you are a stakeholder for this issue, so should we "backport" it, given the current state that @pierrehilbert mentioned above?

@andrewkroh
Copy link
Member

No need to backport to 8.15. I think as of now there is a BC, and this is more of a nice to have feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants